Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Love 11.4 #57

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Bump to Love 11.4 #57

merged 3 commits into from
Mar 17, 2022

Conversation

alexjgriffith
Copy link

@alexjgriffith alexjgriffith commented Mar 16, 2022

  1. Applied changes made to Love 11.3 for emscripten compatibility to version 11.4.
  2. Tested the compat and release targets.
  3. Added a small enviro for debugging the build (uses the appropriate headers for the release target)
  4. Generalized build_lovejs.sh. You now pass in your paths to the megasource and emsdk
  5. Updated the readme to clarify that emsdk V. 2.0.0 works when compiling (likely need to update game.js to allow for compatibility with the latest version of emscripten)

Closes #53 and #56

@alexjgriffith alexjgriffith changed the title Bump to Love 11.4 - Closes #53 and #56 Bump to Love 11.4 Mar 16, 2022
@Davidobot Davidobot merged commit d53e5e3 into Davidobot:master Mar 17, 2022
@Davidobot
Copy link
Owner

Looks good! Thanks for doing this!

@Davidobot
Copy link
Owner

@alexjgriffith could you please push the appropriate changes to https://github.com/Davidobot/love/tree/emscripten ? (and https://github.com/Davidobot/megasource/tree/emscripten if necessary)

I want to take a crack at implementing #2 (comment)

@alexjgriffith
Copy link
Author

I've created pull requests in your emscripten branch for both Love and the Megasource. I'd recommend creating separate branches for each version of Love that we directly support (So far 11.3 and 11.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A little request about the tool update for 11.4 version of "LOVE"
2 participants