CJSON_SetValuestring: better test for overlapping string

DaveGamble · Aug 25, 2024 · f0c6455 · f0c6455
1 parent 193cd6a
commit f0c6455
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/tests/misc_tests.c b/tests/misc_tests.c
@@ -458,15 +458,19 @@ static void cjson_functions_should_not_crash_with_null_pointers(void)
 
 static void cjson_set_valuestring_should_return_null_if_strings_overlap(void)
 {       
-    cJSON *obj, *obj_dup;
+    cJSON *obj;
     char* str;
+    char* str2;
 
-    obj =  cJSON_Parse("\"fooz\"");
-    obj_dup =  cJSON_Duplicate(obj, 1);
+    obj =  cJSON_Parse("\"foo0z\"");
 
-    str =  cJSON_SetValuestring(obj_dup, "beeez");
-    cJSON_SetValuestring(obj_dup, str);
-    cJSON_SetValuestring(obj_dup, ++str);
+    str =  cJSON_SetValuestring(obj, "abcde");
+    str += 1;
+    /* The string passed to strcpy overlap which is not allowed.*/
+    str2 = cJSON_SetValuestring(obj, str);
+    /* If it overlaps, the string will be messed up.*/
+    TEST_ASSERT_TRUE(strcmp(str, "bcde") == 0);
+    TEST_ASSERT_NULL(str2);
 }
 
 static void *CJSON_CDECL failing_realloc(void *pointer, size_t size)