Fix Clear UI with correct answers #35
Conversation
|
How does it work? I'll add a bit more context to the original issue |
|
I think this is not right behavior because it doesn't show the correct answer in Q2, and the original problem is still there - the correct answer is selected in the last picture |
|
Perhaps we could just add a line saying "no answer was submitted"? or something like that |
|
what I understand from the context you just added is that if a student submits homework and there is a question he doesn't submit we display the correct answer as well as a "no answer was submitted" label and if he chooses the wrong answer for a question we display the correct answer as well as the wrong answer like the old behavior. here is what I think you want scenario1: student not answer a question
scenario2: student does not submit a homework
|
|
Looks great! I think for both scenarios it could be the same UI - i.e. the yellow thing with "no answer was submitted" is okay for scenario 2, I think. What do you think? |
|
I think it will be ok to add it as well to homework that the student has not submitted, and what if we change the label from "No answer was submitted" to "Question not answered" for clarity |
final versionscenario1: student not answer a question
scenario2: student does not submit a homework
|
|
looks great! can you please update the code? will be happy to accept it |
|
okay just checked - it looks like the code is updated. is it the final version? |
|
I think adding some tests will not hurt. Do they pass now? |
case when the user answers a question incorrectly
before
after
case when the users don't answer a question
@alexeygrigorev