Feature 67 mn base url prop #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artntek
requested review from
mbjones,
datadavev and
taojing2002
as code owners
artntek
commented
Mar 21, 2024
There was a problem hiding this comment.
no code changes in this file - only a reformat and typo fixes in logging
artntek
commented
Mar 21, 2024
taojing2002
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #67
The next step is to clean up the index.d1node.baseURL from the metacat codebase, but note that this PR is backwards (forwards?) compatible - i.e. it should not require any changes in order for indexer to continue working when co-deployed with metacat.