Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/collective update #4

Merged
merged 19 commits into from
May 14, 2024
Merged

Release/collective update #4

merged 19 commits into from
May 14, 2024

Conversation

luis-dk
Copy link
Contributor

@luis-dk luis-dk commented May 14, 2024

Features

  • implement a cascade delete of entities (2a0c5dd)
  • ui: add some refresh icons (1115b22)
  • profiling: add new profiling details view (d71b19b)

Bug Fixes

  • redshift: handle all null target column (4100b09)
  • synapse: add autocommit to connection params (a95d8e1)
  • snowflake: sampling limit set to 999000 (304fa8b)
  • plugins: enhance plugin support (0ea6cdc)
  • db: set initial revision to start at 0100 (e114945)
  • test generation: allow nullable generation set (41008af)
  • profiling: excel exports show datetime in user tz (f302dc9)
  • ui: hide 'reveal password' icon button (464a35d)
  • tests: fix bad zip errors for mssql (e4ef89c)
  • several pre-release bug fixes (db110d5)
  • test generation: avoid deleting manual cat tests (beedd9c)

Refactors

  • linting: fix linting issues (7852152)
  • typing: fix mypy reported issues (f94dcde)
  • table groups: preview dialog visuals (fba6530)

Copy link

github-actions bot commented May 14, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
testgen
   __main__.py3443440%1–770
testgen/commands
   run_execute_cat_tests.py867511%18–24, 30–32, 37–40, 45–54, 59–60, 64–65, 72–159
   run_execute_tests.py827012%24–109, 113–123, 128–156
   run_generate_tests.py53487%10–103
   run_get_entities.py705322%9–13, 17–18, 22–23, 27–28, 32–35, 39–41, 45–47, 51–56, 60–67, 71–78, 82–87, 91–96, 100–105, 109–117
   run_profiling_bridge.py2672524%24, 28–37, 42–102, 126–214, 218–221, 225–467
   run_quick_start.py84840%1–160
   run_test_parameter_validation.py74695%12–132
testgen/commands/queries
   execute_cat_tests_query.py664137%25–32, 35–64, 68–69, 73–74, 78–79, 82–83, 86–87, 90–91, 94–95
   generate_tests_query.py674426%22–25, 29, 32–45, 48–52, 55–59, 64–80, 83–86, 89–92
testgen/common
   date_service.py463419%7, 15–18, 22, 26–28, 32–44, 48–50, 56–63, 67–68
   read_file.py482244%20–>22, 25, 34–35, 38, 44–48, 53–67
testgen/common/database/flavor
   mssql_flavor_service.py22220%1–39
testgen/ui
   app.py60600%1–100
   bootstrap.py49490%1–105
testgen/ui/components/utils
   callbacks.py251439%18–31, 37–>42, 44–51
testgen/ui/navigation
   router.py412725%27–35, 38–61
testgen/ui/queries
   connection_queries.py302125%8–17, 21–31, 35–37, 41–58, 62–80, 84–90
   profiling_queries.py392241%9–10, 15–30, 35–44, 49–56, 61–62, 67–78, 83–147
   table_group_queries.py503621%7, 21–25, 29–35, 39–57, 61–65, 70–75, 79–97, 101–132, 136–142, 146–163
   test_definition_queries.py604913%7–15, 19–31, 36–99, 103–158, 162–255, 259–263, 267–273, 277–283
   test_run_queries.py9623%7–17
   test_suite_queries.py473324%9–23, 27–42, 46–67, 71–77, 81–87, 91–99, 104–108, 112–124, 128–133, 137–145
testgen/ui/services
   connection_service.py1109115%18–28, 32–41, 45–48, 52–55, 59–61, 65–75, 79–81, 85–89, 94–124, 128–154, 158–160, 164–181
   form_service.py45136712%88–99, 102–107, 111–176, 183–256, 263, 276–279, 283–284, 288–289, 293–294, 298–299, 305–354, 359–373, 377–390, 396–423, 427–438, 445–456, 460–468, 474–491, 495–496, 502–556, 562–581, 587–613, 617–631, 646–663, 676–749, 762–796, 808–938, 942, 953–972, 979–1008
   table_group_service.py947914%10–11, 15–16, 20–21, 25–26, 30–36, 40–45, 49–60, 64–68, 73–118, 122–130
   test_definition_service.py725519%11–13, 19–20, 26–31, 35–37, 41–43, 47–49, 53–57, 62–76, 80–82, 86–91, 95–112
   test_run_service.py5260%7–8
   test_suite_service.py544218%8–9, 13–14, 18–19, 23–30, 34–36, 40–44, 48–61, 65–70, 74–76
testgen/ui/views
   connections.py1291290%1–275
   profiling_anomalies.py1991990%1–510
   profiling_details.py15212713%12–26, 31–54, 58–64, 68–78, 82–85, 89–91, 95–97, 101–103, 107–119, 123–125, 129–131, 135–139, 143–145, 149–173, 177–213, 218–241, 246–291, 295–330
   profiling_results.py72720%1–206
   profiling_summary.py65650%1–152
   table_groups.py1991990%1–456
   test_definitions.py4664129%22–>exit, 33–166, 182–219, 223–240, 255–628, 632–641, 645–659, 663–673, 677–681, 687–821, 825–849, 854–855, 860–861, 866–867, 872–873, 878–879, 884–885, 890–891, 895–910, 914–936, 940–957, 961–976, 980–984, 988–990
   test_results.py32627212%27–>exit, 33–133, 143–144, 149–150, 155–163, 168–169, 174–239, 244–256, 261–276, 281–297, 302–303, 307–319, 324–325, 330–397, 402–443, 447–510, 520–636, 640–703, 707–781, 785–796, 800–838, 842–860, 864–870
   test_suites.py2782507%22–>exit, 28–150, 170–232, 236–300, 304–345, 349–446, 450–477, 483–487, 491–496, 500–505, 509–538
testgen/utils
   plugins.py12120%1–17
TOTAL6739548715% 

Tests Skipped Failures Errors Time
19 0 💤 0 ❌ 0 🔥 3.065s ⏱️

luis-dk added 19 commits May 14, 2024 12:56
Unify the base configuration for Ruff by extending the pyproject.toml
from the public repo. Also fixes all linting errors.
Add some missing params and return types and guard against possible None
return values
Fixes two test types in redshift flavor that were failing for target
columns where all values are null.
Add a refresh icon in the toolbars for Data Profile and Data Quality
Testing pages.
Fixes an error where the sampling query could request over 1M records
when Snowflake has 1M records hard limit itself.
Before the fix, the date fields in the exported excel were being
displayed in UTC timezone.
Avoid users from reveling secrets from password fields.
Test types 'Valid_US_Zip' and 'Valid_US_Zip3' in MSSQL were flagging
null values incorrectly as bad zips.
Tests generation was deleting test types that cannot be auto re-
generated.
@luis-dk luis-dk force-pushed the release/collective-update branch from 54484a1 to 6f2fd59 Compare May 14, 2024 16:57
@luis-dk luis-dk requested a review from aarthy-dk May 14, 2024 16:58
@luis-dk luis-dk merged commit f2cfa68 into main May 14, 2024
3 of 5 checks passed
@luis-dk luis-dk deleted the release/collective-update branch May 14, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants