Add Resources to Cloudflare Terraform Provider #2633
Conversation
| @@ -33,6 +33,7 @@ resource "datadog_integration_cloudflare_account" "foo" { | |||
| ### Optional | |||
|
|
|||
| - `email` (String) The email associated with the Cloudflare account. If an API key is provided (and not a token), this field is also required. | |||
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including 'web', 'dns', 'lb' (load balancer), 'worker') | |||
There was a problem hiding this comment.
Are web, dns, etc. tags on the metrics? Or something else?
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including 'web', 'dns', 'lb' (load balancer), 'worker') | |
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including `web`, `dns`, `lb` (load balancer), `worker`) |
There was a problem hiding this comment.
These are enabling which resources to collect when provisioning a cloudflare account via terraform.
apiazza-dd
force-pushed
the
apiazza-dd/add-resources-to-cloudflare-terrraform-provider
branch
from
9db2b45 to
8b68c39
Compare
…uring a Cloudflare account using the Terraform Provider and update tests accordingly.
apiazza-dd
force-pushed
the
apiazza-dd/add-resources-to-cloudflare-terrraform-provider
branch
from
7f94ba1 to
3788560
Compare
| @@ -33,6 +33,7 @@ resource "datadog_integration_cloudflare_account" "foo" { | |||
| ### Optional | |||
|
|
|||
| - `email` (String) The email associated with the Cloudflare account. If an API key is provided (and not a token), this field is also required. | |||
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including `web`, `dns`, `lb` (load balancer), `worker`) | |||
There was a problem hiding this comment.
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including `web`, `dns`, `lb` (load balancer), `worker`) | |
| - `resources` (List of String) An allowlist of resources, such as `web`, `dns`, `lb` (load balancer), `worker`, that restricts pulling metrics for those resources. |
There was a problem hiding this comment.
I think the restriction part is important here, by default, they're set to all, but if they want one turned off, then they use the resources list. Phrasing as an allow list makes it seem like if they specify one, they'll collect metrics for it, when it's the opposite.
There was a problem hiding this comment.
@apiazza-dd Ah okay, thanks for the clarification. I updated the suggestion, what do you think?
There was a problem hiding this comment.
@apiazza-dd actually rereading your comment, I might have misunderstood.
but if they want one turned off, then they use the resources list.
Is the allowlist of resources, the resources that users want to pull metrics for or the resources they don't want pulling metrics for? If it's the latter, i think i'm throw off by it being called an allowlist
There was a problem hiding this comment.
@maycmlee These docs are autogenerated and have been updated to match our other repository. Does this look okay, or should I make a change in the other repo?
There was a problem hiding this comment.
DM'd. Docs are autogenerated so the suggestion will be updated in the other repo.
There was a problem hiding this comment.
…grationCloudflareAccountUpdateRequestBody to make sure this data is in the payload
apiazza-dd
force-pushed
the
apiazza-dd/add-resources-to-cloudflare-terrraform-provider
branch
from
2b4ad10 to
6e4db55
Compare
| @@ -33,6 +33,7 @@ resource "datadog_integration_cloudflare_account" "foo" { | |||
| ### Optional | |||
|
|
|||
| - `email` (String) The email associated with the Cloudflare account. If an API key is provided (and not a token), this field is also required. | |||
| - `resources` (List of String) An allowlist of resources to restrict pulling metrics for including `web`, `dns`, `lb` (load balancer), `worker`) | |||
There was a problem hiding this comment.
DM'd. Docs are autogenerated so the suggestion will be updated in the other repo.
apiazza-dd
dismissed stale reviews from ZacharyAnderson and maycmlee
via
3659a3d
apiazza-dd
force-pushed
the
apiazza-dd/add-resources-to-cloudflare-terrraform-provider
branch
from
d1d7c94 to
6327791
Compare
skarimo
deleted the
apiazza-dd/add-resources-to-cloudflare-terrraform-provider
branch
* Allow customers to provision which resources they collect when configuring a Cloudflare account using the Terraform Provider and update tests accordingly.
This PR allows customers to provision resources for their Cloudflare Accounts using Terraform.