Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_security_monitoring_rule] Add reference_tables field to security monitoring rule resource #2610

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[datadog_security_monitoring_rule] Add reference_tables field to security monitoring rule resource #2610

merged 3 commits into from
Oct 16, 2024

Conversation

paul-hf
Copy link
Contributor

@paul-hf paul-hf commented Oct 7, 2024

  • Adds a new field reference_tables to the security monitoring rule resource
  • Tested creating, reading, and updating rules with reference tables via terraform on staging
  • Jira

@paul-hf paul-hf requested review from a team as code owners October 7, 2024 18:44
hestonhoffman
hestonhoffman previously approved these changes Oct 7, 2024
View reviewed changes
pietrodll
pietrodll approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@pietrodll pietrodll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@paul-hf
Copy link
Contributor Author

paul-hf commented Oct 16, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 16, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in master is 3m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit fe447fb into master Oct 16, 2024
18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paul-hf/secmon_reference_tables branch October 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaskara-dd amaskara-dd amaskara-dd approved these changes

@pietrodll pietrodll pietrodll approved these changes

@hestonhoffman hestonhoffman hestonhoffman left review comments

Assignees
No one assigned
Labels
changelog/feature mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paul-hf @hestonhoffman @pietrodll @amaskara-dd