-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resource_datadog_dashboard] add support for toplist widget styles in dashboards #2566
Conversation
5c6a1fb
to
d1c2630
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but looks like there are conflicting go versions causing checks to fail
@hyungl ah yep, goimports had a release yesterday which is why it has that go version error. api-clients team is aware of the issue |
remove commment
ecbc668
to
2a0a8b6
Compare
@hestonhoffman @hyungl sorry to re-request reviews on this... will stop rebasing and just merge from now on |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Background:
This PR is backed on the api-spec change https://github.com/DataDog/datadog-api-spec/pull/3088 which adds the
palette
field to a toplist widget's styleThis PR:
To Test:
terraform apply