-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_synthetics_test] Add validation on synthetics test header #2469
Merged
HantingZhang2
merged 3 commits into
master
from
hzhang-add-validation-for-synthetics-test-header
Jul 2, 2024
Merged
[datadog_synthetics_test] Add validation on synthetics test header #2469
HantingZhang2
merged 3 commits into
master
from
hzhang-add-validation-for-synthetics-test-header
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HantingZhang2
changed the title
Adds validation on synthetics test header
[datadog_synthetics_test] Adds validation on synthetics test header
Jun 28, 2024
HantingZhang2
changed the title
[datadog_synthetics_test] Adds validation on synthetics test header
[datadog_synthetics_test] add validation on synthetics test header
Jun 28, 2024
nkzou
requested changes
Jun 28, 2024
buraizu
previously approved these changes
Jun 28, 2024
HantingZhang2
changed the title
[datadog_synthetics_test] add validation on synthetics test header
[datadog_synthetics_test] Add validation on synthetics test header
Jul 1, 2024
etnbrd
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo getting back the documentation as mentioned by @nkzou.
etnbrd
approved these changes
Jul 1, 2024
nkzou
approved these changes
Jul 1, 2024
HantingZhang2
deleted the
hzhang-add-validation-for-synthetics-test-header
branch
July 2, 2024 11:21
bharling
pushed a commit
to bharling/terraform-provider-datadog
that referenced
this pull request
Jul 8, 2024
…ataDog#2469) * Adds validation * update docs * use validateFunc and expand validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synthetics resource now validates that the provided headers don't have new line characters
fix #2462