[datadog_synthetics_test] Remove request_definition.timeout default value
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnbrd
previously approved these changes
Jun 27, 2024
This was referenced Jun 28, 2024
nkzou
force-pushed
the
corentin.girard/SYNTH-14611/fix_monitor_options_renotify_interval
branch
from
102ac28 to
b1d5b02
Compare
Base automatically changed from
corentin.girard/SYNTH-14611/fix_monitor_options_renotify_interval
to
master
July 5, 2024 14:42
nkzou
force-pushed
the
corentin.girard/SYNTH-14611/remove-request-definition-timeout-default-value
branch
from
55cf5f6 to
a301eeb
Compare
michaelcretzman
approved these changes
Jul 5, 2024
nkzou
approved these changes
Jul 5, 2024
nkzou
deleted the
corentin.girard/SYNTH-14611/remove-request-definition-timeout-default-value
branch
bharling
pushed a commit
to bharling/terraform-provider-datadog
that referenced
this pull request
Jul 8, 2024
… value (DataDog#2459) * [datadog_synthetics_test] Remove default `request_definition.timeout` * Remove `DiffSuppressFunc` * update cassettes * make docs --------- Co-authored-by: Kevin Zou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR stack, here is how it's organized:
unarygRPC steps in multistep API tests #2445renotify_intervaldrift when saving from UI #2457http_version#2406request_definition.timeoutdefault value #2459 (← you are here)In #1497, we added the same value in TF as in the UI to fix a bug where the timeout was set to
0.But always hardcoding the default value has a side effect: the UI says that 1 option is configured, which isn't exactly right when users do not have a
request_definition.timeoutset in TF.Our backend now ignores
0for a timeout, so we can remove the default value from TF and ensure the change is backwards compatible (i.e. doesn't generate diffs when planning/applying)