[datadog_monitor] Handle zero-based priority values #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaodingyd
previously approved these changes
Jun 24, 2024
carlmartensen
force-pushed
the
carl/datadog-monitor-zero-priority-value
branch
from
afbc7bc to
1614e5f
Compare
…r-zero-priority-value
…r-zero-priority-value
nkzou
reviewed
Jul 8, 2024
nkzou
requested changes
Jul 9, 2024
nkzou
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the upcoming zero-based monitor priority values. Terraform was storing
priority = nullas0in the state which means that a monitor priority changed fromnullto0would not detect a state change. To work around this, the schema type is switched from int to string so the change is detected. Users can still enter integer values for priority despite the schema change.This solution has the drawback of
terraform applyonpriority=nullpre-existing monitors stating a change was applied as the terraform state is updated from0to"".terraform plancorrectly states no change in this case.The implemented solution was discussed with the Api Clients team and determined to be the best path forward.