Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadog_organization_settings] Add Security Contacts support #2396

Merged
merged 3 commits into from
Jun 27, 2024
Merged

[datadog_organization_settings] Add Security Contacts support #2396

merged 3 commits into from
Jun 27, 2024

Conversation

alexandre-pocquet
Copy link
Contributor

Security Contacts can be configured on a Datadog organization to receive security notification.
Currently users must manually set this setting in the Datadog web UI.

This pull request makes it possible to do it from Terraform as well within a datadog_organization_settings resource.

Example:

resource datadog_organization_settings my_org {
    name = "My Organization"
    security_contacts = ["[email protected]", "[email protected]"]
}

@alexandre-pocquet alexandre-pocquet requested a review from a team May 7, 2024 07:45
@alexandre-pocquet alexandre-pocquet marked this pull request as ready for review May 7, 2024 08:32
@alexandre-pocquet alexandre-pocquet requested review from a team as code owners May 7, 2024 08:32
@alexandre-pocquet alexandre-pocquet requested a review from amymluo May 7, 2024 08:32
maycmlee
maycmlee previously approved these changes May 7, 2024
View reviewed changes
@alexandre-pocquet alexandre-pocquet changed the title Add Security Contacts support in datadog_organization_settings [datadog_organization_settings] Add Security Contacts support May 13, 2024
@sseg-dd sseg-dd requested review from louisthaboogie and a team May 13, 2024 14:23
@alexandre-pocquet alexandre-pocquet force-pushed the alexandre.pocquet/security-contacts branch from 6ebbb13 to 73662b2 Compare June 19, 2024 09:51
daisukixci
daisukixci approved these changes Jun 20, 2024
View reviewed changes
Copy link

@daisukixci daisukixci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from T&S perspective

dshivara
dshivara approved these changes Jun 26, 2024
View reviewed changes
Copy link

@dshivara dshivara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Core-app perspective

@nkzou nkzou merged commit 1e70655 into master Jun 27, 2024
10 checks passed
@nkzou nkzou deleted the alexandre.pocquet/security-contacts branch June 27, 2024 16:39
bharling pushed a commit to bharling/terraform-provider-datadog that referenced this pull request Jul 8, 2024
@alexandre-pocquet @bharling
[datadog_organization_settings] Add Security Contacts support (DataDo…
1a83d23 
…g#2396)

* Upgrade datadog-api-client-go to v2.26.1-0.20240618193852-3e8041dde616

* Fix resource_datadog_organization_settings_test.go test naming

* Add Security Contacts support in datadog_organization_settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkzou nkzou nkzou approved these changes

@dshivara dshivara dshivara approved these changes

@daisukixci daisukixci daisukixci approved these changes

@maycmlee maycmlee maycmlee left review comments

@amymluo amymluo Awaiting requested review from amymluo amymluo was automatically assigned from DataDog/dashboards

@louisthaboogie louisthaboogie Awaiting requested review from louisthaboogie

Assignees
No one assigned
Labels
changelog/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexandre-pocquet @daisukixci @maycmlee @dshivara @nkzou