Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_synthetics_test] Fix no_saving_response_body option to the request config for multi api test #2249

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

RomainGuarinoni
Copy link
Contributor

@RomainGuarinoni RomainGuarinoni commented Jan 18, 2024

SYNTH-12186
Fix a bug where the no_saving_response_body option of the request config for a multi API test was not take into account at the request creation for the API.

Even if user set this option to true, the created test always had this option set to false. This PR fix that

@RomainGuarinoni RomainGuarinoni changed the title fix: add no_saving_response_body to the request config for multi api [SYNTH-12186] Add no_saving_response_body to the request config for multi api test Jan 18, 2024
@RomainGuarinoni RomainGuarinoni marked this pull request as ready for review January 19, 2024 13:11
@RomainGuarinoni RomainGuarinoni requested review from a team as code owners January 19, 2024 13:11
@RomainGuarinoni RomainGuarinoni changed the title [SYNTH-12186] Add no_saving_response_body to the request config for multi api test [datadog_synthetics_test] Fix no_saving_response_body option to the request config for multi api test Jan 19, 2024
AlaricCalmette
AlaricCalmette previously approved these changes Jan 19, 2024
@skarimo skarimo merged commit 0dfd8b4 into master Jan 19, 2024
9 checks passed
@skarimo skarimo deleted the romain.guarinoni/fix-no-saving-body-multi-step branch January 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants