Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_downtimes_schedule] Fix downtimes schedule with monitor id identifier #2092

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

skarimo
Copy link
Member

@skarimo skarimo commented Sep 5, 2023

We need to set the types.Set explicitly to null other wise it will default to model type which omits the element type. I will put up a follow up pr for more permanent fix.

E.g.:

type MonitorIdentifierModel struct {
	DowntimeMonitorIdentifierId   types.Int64 `tfsdk:"monitor_id"`
	DowntimeMonitorIdentifierTags types.Set   `tfsdk:"monitor_tags"`
}

Expected type in schema:

types.Set<types.StringType>

@skarimo skarimo requested a review from a team as a code owner September 5, 2023 15:29
@skarimo skarimo merged commit 4613864 into master Sep 5, 2023
9 checks passed
@skarimo skarimo deleted the sherz/fix-downtimes-schedule branch September 5, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants