[datadog_dashboard] Add support for sunburst widget request style #2089
Conversation
nkzou
changed the title
| @@ -5926,6 +5926,16 @@ func getSunburstRequestSchema() map[string]*schema.Schema { | |||
| // "query" and "formula" go together | |||
| "query": getFormulaQuerySchema(), | |||
| "formula": getFormulaSchema(), | |||
| // Settings specific to Sunburst requests | |||
| "style": { | |||
| Description: "Define style for the widget's request.", | |||
There was a problem hiding this comment.
FYI, I flipped the wording compared to how Heatmaps describe this. (I think it makes more sense this way, but let me know if I should change it.)
|
|
||
| Optional: | ||
|
|
||
| - `palette` (String) A color palette to apply to the widget. The available options are available at: https://docs.datadoghq.com/dashboards/widgets/timeseries/#appearance. |
There was a problem hiding this comment.
question: Is it intentional that we're linking to the timeseries docs here? If these docs are generated then we may need to fix it upstream
There was a problem hiding this comment.
Looks like most of the widget request styles share the same schema from getWidgetRequestStyle() line 9192 of resource_datadog_dashboard.go. Is there a more generic list of styles that could be linked to?
There was a problem hiding this comment.
I didn't really want to rock the boat here; but, offhand, https://docs.datadoghq.com/dashboards/guide/widget_colors/ looks like a better page; at the very least we should replace #appearance with #color so it links right.
I'll run this by Dataviz and see what they advise.
There was a problem hiding this comment.
Update: it's on their radar. They're going to do a review of color docs, as I think there are a few more stale things beyond just this.
|
|
||
| Optional: | ||
|
|
||
| - `palette` (String) A color palette to apply to the widget. The available options are available at: https://docs.datadoghq.com/dashboards/widgets/timeseries/#appearance. |
There was a problem hiding this comment.
question: Is it intentional that we're linking to the timeseries docs here? If these docs are generated then we may need to fix it upstream
Adding the a missing style property to sunburst widget requests. Corresponding Go client PR: DataDog/datadog-api-client-go#2158.