Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a fake API key of length 32 #3569

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

When the key is not length 32, the agent can stops itself :

https://github.com/DataDog/datadog-agent/blob/90535e90a71d31df934738c8b5738c806ffea8eb/pkg/api/security/security.go#L166
https://github.com/DataDog/system-tests-dashboard/actions/runs/12044074813/job/33580719639#step:49:86
https://datadoghq.atlassian.net/browse/APMSP-1600

Changes

Use a fake key with a length of 32 characters

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review November 27, 2024 11:46
@cbeauchesne cbeauchesne requested a review from a team as a code owner November 27, 2024 11:46
@cbeauchesne cbeauchesne merged commit 49eb4ae into main Nov 27, 2024
396 of 397 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/fake-key-size branch November 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant