Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document incomplete_test_app decorator #3561

Open
wants to merge 1 commit into
base: munir/add-incomplete-test-annotation
Choose a base branch
from
Open

document incomplete_test_app decorator #3561

wants to merge 1 commit into from

Conversation

mabdinur
Copy link
Contributor

Motivation

Follow up to: #3551

Changes

  • Adds documentation for incomplete_test_app.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur marked this pull request as ready for review November 26, 2024 17:49
@mabdinur mabdinur requested a review from a team as a code owner November 26, 2024 17:49
cbeauchesne
cbeauchesne reviewed Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a concurrent of the main one ?

@mabdinur mabdinur changed the base branch from main to munir/add-incomplete-test-annotation November 27, 2024 18:45
@mabdinur
Copy link
Contributor Author

mabdinur commented Nov 27, 2024 •
edited
Loading

This PR is a concurrent of the main one ?

I updated the base branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne left review comments

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabdinur @cbeauchesne