Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] add nodejs docker_ssi test app #3530

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

brettlangdon
Copy link
Member

Motivation

Enable DOCKER_SSI scenario for Node.js.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@brettlangdon brettlangdon added javascript Pull requests that update Javascript code run-docker-ssi-scenarios labels Nov 22, 2024
@brettlangdon brettlangdon requested a review from a team as a code owner November 22, 2024 02:41
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes suggested here:
https://github.com/DataDog/system-tests/pull/3533/files
After these changes, some jobs will start working. But others don't work. Take a look at this pipeline: https://gitlab.ddbuild.io/DataDog/system-tests/-/pipelines/49716395
Feel free to merge my PR in yours PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code run-docker-ssi-scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants