-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] remove INPLAT-220 skips from test cases #3523
base: main
Are you sure you want to change the base?
Conversation
I think this first needs a release of |
These jobs are still failing. I need to dig into the logs to see if it is the same issue or not. |
@emmettbutler any ideas? This should be passing.. right?
NVM! I thought the change went out in 2.17.0, but we are waiting on a backport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested using prod and dev environment. In both cases is failing.
The dev environment is using this artifacts:
datadog-apm-inject: 0.23.0-dev.b0d6e40.glci714805095.g7293f2e7
datadog-apm-library: 2.18.0.dev37+gbad0d272e
is the library version ok? are we uploading the library artifact to staging?
That dev artifact looks good to me, at least the version string looks correct. I'll have to check the logs for dev. But the fix is not yet released to "prod", but maybe we need to do some extra manual testing to verify too. |
Here you can see the logs for last execution I launched for dev: https://gitlab.ddbuild.io/DataDog/system-tests/-/jobs/716697641 If we achieve getting work for dev, I can add a marker like "missing_feature tracer < xx.xx.xx" |
@robertomonteromiguel what determines which version to use for "dev", that commit is like 3 days old, so it doesn't have the most recent changes on |
Motivation
DataDog/dd-trace-py#11464 has been merged fixing this bug. Tests should be enabled again.
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present