Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] remove INPLAT-220 skips from test cases #3523

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brettlangdon
Copy link
Member

Motivation

DataDog/dd-trace-py#11464 has been merged fixing this bug. Tests should be enabled again.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@brettlangdon
Copy link
Member Author

I think this first needs a release of ddtrace to PyPI fixing the issue first before the tests will pass.

@brettlangdon
Copy link
Member Author

These jobs are still failing. I need to dig into the logs to see if it is the same issue or not.

@brettlangdon
Copy link
Member Author

brettlangdon commented Nov 21, 2024

@emmettbutler any ideas? This should be passing.. right?

[2024-11-21 13:37:51] [DEBUG] datadog.autoinstrumentation(pid: 9602): Found incompatible packages: {'jinja2': '2.10.1', 'click': '7.0'}.

NVM! I thought the change went out in 2.17.0, but we are waiting on a backport.

Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using prod and dev environment. In both cases is failing.
The dev environment is using this artifacts:

datadog-apm-inject: 0.23.0-dev.b0d6e40.glci714805095.g7293f2e7
datadog-apm-library: 2.18.0.dev37+gbad0d272e

is the library version ok? are we uploading the library artifact to staging?

@brettlangdon
Copy link
Member Author

That dev artifact looks good to me, at least the version string looks correct.

I'll have to check the logs for dev.

But the fix is not yet released to "prod", but maybe we need to do some extra manual testing to verify too.

@robertomonteromiguel
Copy link
Collaborator

That dev artifact looks good to me, at least the version string looks correct.

I'll have to check the logs for dev.

But the fix is not yet released to "prod", but maybe we need to do some extra manual testing to verify too.

Here you can see the logs for last execution I launched for dev: https://gitlab.ddbuild.io/DataDog/system-tests/-/jobs/716697641

If we achieve getting work for dev, I can add a marker like "missing_feature tracer < xx.xx.xx"

@brettlangdon
Copy link
Member Author

That dev artifact looks good to me, at least the version string looks correct.
I'll have to check the logs for dev.
But the fix is not yet released to "prod", but maybe we need to do some extra manual testing to verify too.

Here you can see the logs for last execution I launched for dev: gitlab.ddbuild.io/DataDog/system-tests/-/jobs/716697641

If we achieve getting work for dev, I can add a marker like "missing_feature tracer < xx.xx.xx"

@robertomonteromiguel what determines which version to use for "dev", that commit is like 3 days old, so it doesn't have the most recent changes on main / including Emmett's fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants