Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parametric: avoids sending non-null default values to trace/otel/start_span #3515

Merged
merged 7 commits into from
Nov 22, 2024

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 20, 2024

Motivation

  • Currently the trace/otel/start_span endpoint receives a default start timestamp of 0, default spankind of unimplemented, and a default parent_id of 0. These default values add unnecessary complexity to parametric endpoints.

Changes

  • Updates the default value of:
    • timestamp from 0 to None
    • span_kind from unimplemented to None
    • parent_id from 0 to None
  • Updates parametric apps to ignore null/unset arguments.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur marked this pull request as ready for review November 21, 2024 20:34
@mabdinur mabdinur requested review from a team as code owners November 21, 2024 20:34
@mabdinur mabdinur requested review from ZStriker19 and romainkomorndatadog and removed request for a team November 21, 2024 20:34
@mabdinur mabdinur requested review from a team as code owners November 21, 2024 21:38
@mabdinur mabdinur force-pushed the munir/update-otel-start-span-to-set-null-values branch from 5acabf3 to 76693e4 Compare November 21, 2024 21:41
@mabdinur mabdinur merged commit ba751d1 into main Nov 22, 2024
398 of 399 checks passed
@mabdinur mabdinur deleted the munir/update-otel-start-span-to-set-null-values branch November 22, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants