Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run.sh on groups #3510

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix run.sh on groups #3510

merged 2 commits into from
Nov 20, 2024

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@shurivich shurivich self-requested a review November 20, 2024 17:31
Copy link
Contributor

@shurivich shurivich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@cbeauchesne cbeauchesne marked this pull request as ready for review November 20, 2024 17:40
@cbeauchesne cbeauchesne requested a review from a team as a code owner November 20, 2024 17:41
@cbeauchesne cbeauchesne merged commit 69058fa into main Nov 20, 2024
396 of 397 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/fix-groups-run branch November 20, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants