Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mypy checks to parametric #3488

Merged
merged 20 commits into from
Nov 21, 2024
Merged

Conversation

rachelyangdog
Copy link
Contributor

@rachelyangdog rachelyangdog commented Nov 18, 2024

Motivation

Update the ./format.sh script to run static analysis checks on parametric tests (via mypy).

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rachelyangdog rachelyangdog requested review from mabdinur and a team as code owners November 18, 2024 20:18
@rachelyangdog rachelyangdog changed the title Rachel.yang/parametric mypy adding mypy checks to parametric Nov 18, 2024
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint fails

format.sh Outdated Show resolved Hide resolved
tests/parametric/test_tracer.py Outdated Show resolved Hide resolved
utils/parametric/_library_client.py Outdated Show resolved Hide resolved
@cbeauchesne
Copy link
Collaborator

I'm setting this PR as draft to destress my notification queue :)

Do not hesitate to ping me if you need help !

@cbeauchesne cbeauchesne marked this pull request as draft November 20, 2024 08:53
@rachelyangdog rachelyangdog marked this pull request as ready for review November 20, 2024 16:33
@rachelyangdog rachelyangdog marked this pull request as draft November 20, 2024 16:46
@rachelyangdog rachelyangdog marked this pull request as ready for review November 21, 2024 15:19
@rachelyangdog rachelyangdog merged commit f946c90 into main Nov 21, 2024
397 checks passed
@rachelyangdog rachelyangdog deleted the rachel.yang/parametric-mypy branch November 21, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants