Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Otel AddEvent API in Go #2747

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Tests for Otel AddEvent API in Go #2747

merged 9 commits into from
Jul 19, 2024

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Jul 12, 2024

Motivation

Tests Span Events functionality in dd-trace-go

Changes were introduced to dd-trace-go in this PR: DataDog/dd-trace-go#2780

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mtoffl01 mtoffl01 marked this pull request as ready for review July 15, 2024 20:17
@mtoffl01 mtoffl01 requested review from Kyle-Verhoog and a team as code owners July 15, 2024 20:17
@mtoffl01 mtoffl01 changed the title add otel addevent handler to go grpc parametric app Tests for Otel AddEvent API in Go Jul 15, 2024
@zacharycmontoya
Copy link
Contributor

Question to system-tests approvers: It looks like the only failures in the parametric suite of tests were Python (failed to build container) and Ruby (failed in unrelated TestDynamicConfigV1 test). Since those are unrelated, would we be able to merge this PR?

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 18, 2024

Library Vulnerabilities

Critical badge  High badge  Medium badge  Low badge

@mtoffl01
Copy link
Contributor Author

Hey @robertomonteromiguel , thank you for reviewing this. I want to confirm the answer to Zach's question before merging:

Question to system-tests approvers: It looks like the only failures in the parametric suite of tests were Python (failed to build container) and Ruby (failed in unrelated TestDynamicConfigV1 test). Since those are unrelated, would we be able to merge this PR?

@robertomonteromiguel
Copy link
Collaborator

Hey @robertomonteromiguel , thank you for reviewing this. I want to confirm the answer to Zach's question before merging:

Question to system-tests approvers: It looks like the only failures in the parametric suite of tests were Python (failed to build container) and Ruby (failed in unrelated TestDynamicConfigV1 test). Since those are unrelated, would we be able to merge this PR?

Yes, This PR can be merged

@mtoffl01 mtoffl01 merged commit 87fa057 into main Jul 19, 2024
326 of 328 checks passed
@mtoffl01 mtoffl01 deleted the mtoff/go-otel-systests branch July 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants