Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET OTEL/Activity SpanLinks Setup & Configuration #2543

Merged
merged 19 commits into from
Jun 14, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Jun 10, 2024

Motivation

To test the SpanLinks implementation merged in DataDog/dd-trace-dotnet#5627 after being able to pass them locally.

Changes

Updates the .NET service OTEL parametric class to check for the links in the incoming request and try to add them like a user would using the ActivityLink class which the .NET tracer now is able to duck cast and add to its spans.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@link04 link04 added dotnet Pull requests that update .NET code run-parametric-scenario labels Jun 10, 2024
@link04 link04 marked this pull request as ready for review June 12, 2024 20:21
@link04 link04 requested review from Kyle-Verhoog and a team as code owners June 12, 2024 20:21
Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zacharycmontoya zacharycmontoya merged commit f4df52e into main Jun 14, 2024
309 of 319 checks passed
@zacharycmontoya zacharycmontoya deleted the maximo/span-links-dotnet branch June 14, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Pull requests that update .NET code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants