Skip to content

Commit

Permalink
parametric: re-enable config consistency tests for ruby (#3381)
Browse files Browse the repository at this point in the history
Co-authored-by: Charles de Beauchesne <[email protected]>
  • Loading branch information
mabdinur and cbeauchesne authored Nov 20, 2024
1 parent 869f1f7 commit db3d3bb
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/parametric/test_config_consistency.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def test_default_config(self, library_env, test_agent, test_library):

# Assert that iff a span has service name set by DD_SERVICE, it also gets the version specified in DD_VERSION
@parametrize("library_env", [{"DD_SERVICE": "version_test", "DD_VERSION": "5.2.0"}])
@missing_feature(library="ruby")
@missing_feature(context.library < "ruby@2.7.1-dev")
def test_specific_version(self, library_env, test_agent, test_library):
with test_library:
with test_library.start_span(name="s1") as s1:
Expand Down Expand Up @@ -132,7 +132,6 @@ class Test_Config_TraceAgentURL:
which would be unnecessarily complex.
"""

@missing_feature(library="ruby")
@parametrize(
"library_env",
[
Expand All @@ -148,7 +147,7 @@ def test_dd_trace_agent_unix_url_nonexistent(self, library_env, test_agent, test
resp = t.get_tracer_config()

url = urlparse(resp["dd_trace_agent_url"])
assert url.scheme == "unix"
assert "unix" in url.scheme
assert url.path == "/var/run/datadog/apm.socket"

# The DD_TRACE_AGENT_URL is validated using the tracer configuration. This approach avoids the need to modify the setup file to create additional containers at the specified URL, which would be unnecessarily complex.
Expand Down

0 comments on commit db3d3bb

Please sign in to comment.