Skip to content

Commit

Permalink
unskip some passing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cbeauchesne committed Nov 27, 2024
1 parent 14cfabf commit cbaa285
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 0 additions & 2 deletions manifests/cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,6 @@ tests/:
test_identify.py: irrelevant
test_library_conf.py: irrelevant
test_miscs.py: irrelevant
test_profiling.py:
Test_Profile: bug (No Content-Disposition, tests do not parse the content correcly)
test_scrubbing.py: irrelevant
test_standard_tags.py: irrelevant
test_telemetry.py:
Expand Down
7 changes: 2 additions & 5 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,6 @@ allow_no_jira_ticket_for_bugs = [
# agent
"tests/test_schemas.py::Test_Agent.test_agent_schema_telemetry_main_payload",

# cpp
"tests/parametric/test_span_sampling.py::Test_Span_Sampling.test_single_rule_rate_limiter_span_sampling_sss008",

# dotnet
"tests/integrations/test_dbm.py::Test_Dbm.test_trace_payload_service",

Expand All @@ -71,10 +68,10 @@ allow_no_jira_ticket_for_bugs = [
# nodejs and golang
"tests/parametric/test_trace_sampling.py::Test_Trace_Sampling_Tags_Feb2024_Revision.test_metric_existence",

# java and cpp
# all but cpp
"tests/parametric/test_span_sampling.py::Test_Span_Sampling.test_multi_rule_independent_rate_limiters_sss013",

# cpp, golang, php, ruby,
# golang, php, ruby , an error was in the deserialize function, probably no issue
"tests/test_profiling.py::Test_Profile",

# all, test must be either removed or fixed
Expand Down
3 changes: 1 addition & 2 deletions tests/parametric/test_span_sampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ def test_multi_rule_drop_keep_span_sampling_sss007(self, test_agent, test_librar
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MECHANISM) is None
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None

@flaky(library="cpp", reason="The test itself is probably flaky")
@missing_feature(
context.library == "php",
reason="PHP uses a float to represent the allowance in tokens and thus accepts one more request (given the time elapsed between individual requests)",
Expand Down Expand Up @@ -399,7 +398,7 @@ def test_single_rule_tracer_always_keep_span_sampling_sss012(self, test_agent, t
assert span["metrics"].get(SINGLE_SPAN_SAMPLING_MAX_PER_SEC) is None
assert span["metrics"].get(SAMPLING_PRIORITY_KEY) > 0

@flaky(reason="intermittent failure in java and cpp")
@flaky(context.library != "cpp", reason="missing JIRA, probably working on some tracers")
@missing_feature(
context.library == "php",
reason="PHP uses a float to represent the allowance in tokens and thus accepts one more request (given the time elapsed between individual requests)",
Expand Down

0 comments on commit cbaa285

Please sign in to comment.