Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support confluent-kafka-go v1 and v2 #320

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 7, 2024

@rarguelloF rarguelloF changed the title feat: add support for github.com/confluentinc/confluent-kafka-go/kafka WIP: feat: support confluent-kafka-go v1 and v2 Oct 7, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.60%. Comparing base (bcf41e6) to head (1b59f4b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   51.98%   58.60%   +6.62%     
==========================================
  Files         149      146       -3     
  Lines        9419     9401      -18     
==========================================
+ Hits         4896     5509     +613     
+ Misses       4140     3431     -709     
- Partials      383      461      +78     
Components Coverage Δ
Generators 78.38% <ø> (+78.38%) ⬆️
Instruments ∅ <ø> (∅)
Go Driver 56.79% <ø> (-23.46%) ⬇️
Toolexec Driver 73.84% <100.00%> (+17.50%) ⬆️
Aspects 74.82% <ø> (+24.26%) ⬆️
Injector 75.27% <ø> (+25.90%) ⬆️
Job Server 55.63% <ø> (-13.46%) ⬇️
Integration Test Suite 52.10% <100.00%> (+2.66%) ⬆️
Other 58.60% <100.00%> (+6.62%) ⬆️
Files with missing lines Coverage Δ
...gration-tests/tests/confluent-kafka-go.v1/kafka.go 100.00% <100.00%> (ø)
...gration-tests/tests/confluent-kafka-go.v2/kafka.go 100.00% <100.00%> (ø)
internal/injector/aspect/join/join.go 69.84% <ø> (+15.87%) ⬆️
internal/toolexec/aspect/oncompile.go 79.62% <100.00%> (+1.41%) ⬆️
internal/toolexec/proxy/compile.go 81.25% <100.00%> (+3.47%) ⬆️

... and 57 files with indirect coverage changes

@rarguelloF rarguelloF marked this pull request as ready for review October 8, 2024 20:14
@rarguelloF rarguelloF requested a review from a team as a code owner October 8, 2024 20:14
@rarguelloF rarguelloF changed the title WIP: feat: support confluent-kafka-go v1 and v2 feat: support confluent-kafka-go v1 and v2 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants