Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support segmentio/kafka.go.v0 #293

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Sep 24, 2024

Adds support for instrumenting segmentio/kafka.go.v0

Requires DataDog/dd-trace-go#2885

@rarguelloF rarguelloF changed the title wip: feat: support segmentio/kafka.go.v0 feat: support segmentio/kafka.go.v0 Sep 25, 2024
@rarguelloF rarguelloF marked this pull request as ready for review September 25, 2024 15:07
@rarguelloF rarguelloF requested a review from a team as a code owner September 25, 2024 15:07
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.20%. Comparing base (1b1f5aa) to head (4d9cd63).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (1b1f5aa) and HEAD (4d9cd63). Click for more details.

HEAD has 38 uploads less than BASE
Flag BASE (1b1f5aa) HEAD (4d9cd63)
Linux 7 1
X64 7 1
go1.23 4 1
unit 2 0
go1.22 5 0
DRIVER 4 0
integration 6 0
TOOLEXEC 1 0
GOFLAGS 1 0
macOS 2 0
ARM64 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #293       +/-   ##
===========================================
- Coverage   78.99%   52.20%   -26.80%     
===========================================
  Files         143       37      -106     
  Lines        6738     2268     -4470     
===========================================
- Hits         5323     1184     -4139     
+ Misses        984      952       -32     
+ Partials      431      132      -299     
Components Coverage Δ
Generators 78.26% <ø> (ø)
Instruments ∅ <ø> (∅)
Go Driver ∅ <ø> (∅)
Toolexec Driver 75.74% <ø> (+1.44%) ⬆️
Aspects 47.84% <ø> (-31.31%) ⬇️
Injector 48.94% <ø> (-29.72%) ⬇️
Job Server ∅ <ø> (∅)
Integration Test Suite 75.67% <ø> (-16.97%) ⬇️
Other 52.20% <ø> (-26.80%) ⬇️

see 133 files with indirect coverage changes

@RomainMuller
Copy link
Contributor

Can you please separate the unrelated changes in their own PR:

  • The removal of -v
  • The renaming of Spans to Traces
  • The change of type of Meta and addition of Metrics
  • The use of t.Cleanup

That'll make this PR easier to review & also will allow easier reverting of any individual part of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants