feat(injector: stdlib): instrument os.OpenFile #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for the dd-trace-go PR to be released |
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/APPSEC-53773
branch
from
1ba115d
to
b74fc7b
Compare
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/APPSEC-53773
branch
from
dde8709
to
1b30daf
Compare
RomainMuller
requested changes
Aug 28, 2024
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
RomainMuller
approved these changes
Aug 29, 2024
Signed-off-by: Eliott Bouhana <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 62.57% 62.67% +0.09%
==========================================
Files 101 101
Lines 5259 5259
==========================================
+ Hits 3291 3296 +5
+ Misses 1627 1623 -4
+ Partials 341 340 -1
|
nsrip-dd
added a commit
to DataDog/dd-trace-go
that referenced
this pull request
Aug 29, 2024
With DataDog/orchestrion#219 merged, the branch we pinned to for the Orchestrion test is gone. Switch back to main so the workflow can run again.
nsrip-dd
added a commit
to DataDog/dd-trace-go
that referenced
this pull request
Aug 29, 2024
With DataDog/orchestrion#219 merged, the branch we pinned to for the Orchestrion test is gone. Switch back to main so the workflow can run again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR instrument all file opening via the
os.Openfilefunction for RASP LFI and is the sister PR of DataDog/dd-trace-go#2781ospackagetracer-internal: trueto thedd:orchestrion-enabledinstrumentation to properly enable the GLS storage in dd-trace-godd:orchestrion-enabledMotivation
Support for LFI protection.
Reviewer's Checklist