Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate Debugger diagnostics in sidecar #736

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Deduplicate Debugger diagnostics in sidecar #736

merged 3 commits into from
Nov 15, 2024

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Nov 13, 2024

We were sending too much data and that made our backend sad.
Sending less data so that our backend can be happy again.

This avoids sending multiple diagnostics for individual runtime ids.

@bwoebi bwoebi requested review from a team as code owners November 13, 2024 15:52
@pr-commenter
Copy link

pr-commenter bot commented Nov 13, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-15 16:42:40

Comparing candidate commit a059912 in PR branch bob/live-debugger-dedup with baseline commit d04fad9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.015ms 9.053ms ± 0.012ms 9.053ms ± 0.007ms 9.061ms 9.073ms 9.079ms 9.082ms 0.32% -0.078 0.072 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.052ms; 9.055ms] or [-0.018%; +0.018%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.682µs 70.875µs ± 0.251µs 70.835µs ± 0.053µs 70.913µs 71.058µs 71.196µs 74.122µs 4.64% 10.897 137.537 0.35% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.841µs; 70.910µs] or [-0.049%; +0.049%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.029µs 140.924µs ± 0.363µs 140.904µs ± 0.154µs 141.061µs 141.393µs 142.451µs 143.071µs 1.54% 1.948 10.239 0.26% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [140.873µs; 140.974µs] or [-0.036%; +0.036%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.976µs 26.823µs ± 11.640µs 18.346µs ± 0.261µs 35.800µs 42.421µs 45.266µs 99.723µs 443.56% 2.321 11.035 43.29% 0.823µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.210µs; 28.436µs] or [-6.014%; +6.014%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.364µs 3.281µs ± 1.416µs 3.130µs ± 0.020µs 3.149µs 3.188µs 14.076µs 15.058µs 381.10% 7.549 57.273 43.06% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.084µs; 3.477µs] or [-5.983%; +5.983%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 505.863µs 507.493µs ± 1.074µs 507.469µs ± 0.311µs 507.768µs 508.230µs 509.245µs 520.204µs 2.51% 8.335 96.630 0.21% 0.076µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1922322.564op/s 1970479.471op/s ± 4097.183op/s 1970563.034op/s ± 1205.927op/s 1971776.227op/s 1974678.053op/s 1976148.008op/s 1976820.960op/s 0.32% -8.152 93.792 0.21% 289.715op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.712µs 468.417µs ± 0.307µs 468.392µs ± 0.206µs 468.617µs 468.953µs 469.147µs 469.463µs 0.23% 0.319 0.139 0.07% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2130095.230op/s 2134851.095op/s ± 1398.399op/s 2134965.676op/s ± 938.791op/s 2135763.037op/s 2136918.041op/s 2137740.168op/s 2138066.908op/s 0.15% -0.315 0.134 0.07% 98.882op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.714µs 180.077µs ± 0.165µs 180.056µs ± 0.111µs 180.185µs 180.376µs 180.484µs 180.575µs 0.29% 0.379 -0.052 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5537876.373op/s 5553175.258op/s ± 5085.106op/s 5553813.782op/s ± 3416.035op/s 5556863.451op/s 5561271.986op/s 5563133.313op/s 5564396.009op/s 0.19% -0.374 -0.058 0.09% 359.571op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.874µs 45.066µs ± 0.074µs 45.066µs ± 0.039µs 45.101µs 45.178µs 45.332µs 45.365µs 0.66% 0.626 2.243 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22043628.875op/s 22189657.582op/s ± 36634.404op/s 22189705.299op/s ± 19159.370op/s 22209705.854op/s 22247415.292op/s 22265585.729op/s 22284531.106op/s 0.43% -0.607 2.193 0.16% 2590.444op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.918µs 49.147µs ± 0.091µs 49.148µs ± 0.061µs 49.208µs 49.309µs 49.346µs 49.412µs 0.54% 0.193 -0.236 0.19% 0.006µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20237941.717op/s 20346986.528op/s ± 37780.363op/s 20346635.696op/s ± 25253.026op/s 20372552.392op/s 20403969.171op/s 20424565.994op/s 20442547.883op/s 0.47% -0.184 -0.240 0.19% 2671.475op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.344µs; 507.642µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1969911.641op/s; 1971047.301op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.374µs; 468.459µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2134657.291op/s; 2135044.900op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.054µs; 180.100µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5552470.511op/s; 5553880.005op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.056µs; 45.076µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22184580.406op/s; 22194734.758op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.135µs; 49.160µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20341750.533op/s; 20352222.523op/s] or [-0.026%; +0.026%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.546ns 305.680ns ± 15.254ns 298.749ns ± 4.122ns 308.808ns 341.126ns 348.084ns 350.560ns 17.34% 1.548 1.149 4.98% 1.079ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [303.565ns; 307.794ns] or [-0.692%; +0.692%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.599µs 4.613µs ± 0.009µs 4.612µs ± 0.007µs 4.619µs 4.628µs 4.631µs 4.633µs 0.47% 0.310 -0.831 0.19% 0.001µs 1 200
credit_card/is_card_number/ throughput 215824876.711op/s 216798468.584op/s ± 417493.727op/s 216836397.222op/s ± 305327.714op/s 217086742.473op/s 217401558.070op/s 217419785.644op/s 217437092.042op/s 0.28% -0.304 -0.836 0.19% 29521.265op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 93.260µs 93.504µs ± 0.317µs 93.457µs ± 0.109µs 93.582µs 93.752µs 94.088µs 97.333µs 4.15% 9.091 105.518 0.34% 0.022µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10273972.274op/s 10694830.926op/s ± 35165.103op/s 10700071.156op/s ± 12491.961op/s 10710979.290op/s 10717830.397op/s 10719494.956op/s 10722730.043op/s 0.21% -8.841 101.341 0.33% 2486.548op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 85.233µs 85.366µs ± 0.336µs 85.317µs ± 0.022µs 85.339µs 85.398µs 86.906µs 89.095µs 4.43% 8.463 80.795 0.39% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11223957.328op/s 11714382.539op/s ± 44680.742op/s 11721037.713op/s ± 3048.826op/s 11724076.056op/s 11727474.544op/s 11730951.082op/s 11732583.403op/s 0.10% -8.335 78.285 0.38% 3159.406op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.599µs 4.613µs ± 0.008µs 4.613µs ± 0.006µs 4.619µs 4.626µs 4.629µs 4.631µs 0.39% 0.028 -0.803 0.17% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 215927183.261op/s 216778662.078op/s ± 377842.770op/s 216767858.334op/s ± 282028.195op/s 217084223.127op/s 217397291.958op/s 217414523.864op/s 217451260.691op/s 0.32% -0.022 -0.806 0.17% 26717.518op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.591µs 82.040µs ± 0.232µs 82.024µs ± 0.121µs 82.144µs 82.340µs 82.755µs 83.440µs 1.73% 1.979 9.351 0.28% 0.016µs 1 200
credit_card/is_card_number/378282246310005 throughput 11984695.836op/s 12189275.960op/s ± 34308.315op/s 12191545.275op/s ± 17975.294op/s 12209950.421op/s 12233896.587op/s 12250094.060op/s 12256305.047op/s 0.53% -1.917 8.939 0.28% 2425.964op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.858µs 58.890µs ± 0.018µs 58.892µs ± 0.014µs 58.904µs 58.916µs 58.932µs 58.962µs 0.12% 0.449 0.404 0.03% 0.001µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16960148.739op/s 16980669.643op/s ± 5110.425op/s 16980136.636op/s ± 4081.494op/s 16985085.397op/s 16987986.860op/s 16988716.638op/s 16990035.344op/s 0.06% -0.447 0.397 0.03% 361.362op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.818µs 6.833µs ± 0.029µs 6.823µs ± 0.003µs 6.826µs 6.897µs 6.913µs 7.062µs 3.50% 4.147 23.281 0.42% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 141598221.061op/s 146361083.759op/s ± 604451.239op/s 146558034.373op/s ± 59261.098op/s 146618171.537op/s 146639854.205op/s 146662169.430op/s 146667468.985op/s 0.07% -4.049 22.068 0.41% 42741.157op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.592µs 4.611µs ± 0.008µs 4.611µs ± 0.007µs 4.618µs 4.626µs 4.630µs 4.634µs 0.50% 0.386 -0.596 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215816514.769op/s 216862632.073op/s ± 396497.558op/s 216887681.699op/s ± 308449.048op/s 217182108.827op/s 217398158.096op/s 217426040.605op/s 217786106.331op/s 0.41% -0.379 -0.603 0.18% 28036.611op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.348µs 73.692µs ± 0.153µs 73.715µs ± 0.097µs 73.787µs 73.906µs 73.958µs 74.510µs 1.08% 0.415 3.082 0.21% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13421045.126op/s 13570095.693op/s ± 28073.456op/s 13565745.814op/s ± 17774.435op/s 13587371.557op/s 13616083.688op/s 13631983.305op/s 13633650.576op/s 0.50% -0.385 2.939 0.21% 1985.093op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.259µs 65.442µs ± 0.136µs 65.434µs ± 0.111µs 65.533µs 65.700µs 65.739µs 65.759µs 0.50% 0.490 -0.749 0.21% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15206983.444op/s 15280708.362op/s ± 31627.677op/s 15282522.912op/s ± 25978.128op/s 15311482.464op/s 15320041.909op/s 15321827.138op/s 15323506.259op/s 0.27% -0.484 -0.759 0.21% 2236.414op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.599µs 4.612µs ± 0.008µs 4.611µs ± 0.006µs 4.617µs 4.628µs 4.628µs 4.629µs 0.39% 0.322 -0.718 0.17% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 216045432.293op/s 216830278.104op/s ± 375362.363op/s 216889903.855op/s ± 284512.900op/s 217121290.020op/s 217394160.842op/s 217436574.111op/s 217452873.932op/s 0.26% -0.316 -0.724 0.17% 26542.127op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.112µs 62.518µs ± 0.138µs 62.502µs ± 0.068µs 62.610µs 62.750µs 62.854µs 62.882µs 0.61% -0.025 0.579 0.22% 0.010µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15902736.100op/s 15995542.891op/s ± 35422.373op/s 15999375.925op/s ± 17449.504op/s 16007323.201op/s 16048204.829op/s 16088737.799op/s 16099962.970op/s 0.63% 0.042 0.586 0.22% 2504.740op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.858µs 58.889µs ± 0.021µs 58.884µs ± 0.014µs 58.901µs 58.927µs 58.940µs 58.950µs 0.11% 0.741 -0.195 0.03% 0.001µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16963629.977op/s 16981227.482op/s ± 5917.174op/s 16982450.336op/s ± 3984.297op/s 16986133.370op/s 16988343.363op/s 16989722.441op/s 16990157.602op/s 0.05% -0.740 -0.197 0.03% 418.407op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.819µs 6.835µs ± 0.032µs 6.823µs ± 0.003µs 6.827µs 6.902µs 6.980µs 7.016µs 2.82% 3.098 10.776 0.46% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 142539928.753op/s 146299773.232op/s ± 668298.891op/s 146563911.980op/s ± 61305.278op/s 146622875.971op/s 146642231.384op/s 146650698.536op/s 146659336.379op/s 0.07% -3.055 10.432 0.46% 47255.868op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.611µs; 4.614µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/ throughput [216740607.968op/s; 216856329.199op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.460µs; 93.548µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10689957.381op/s; 10699704.472op/s] or [-0.046%; +0.046%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [85.320µs; 85.413µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11708190.218op/s; 11720574.860op/s] or [-0.053%; +0.053%] None None None
credit_card/is_card_number/37828224631 execution_time [4.612µs; 4.614µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/37828224631 throughput [216726296.704op/s; 216831027.452op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number/378282246310005 execution_time [82.008µs; 82.072µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/378282246310005 throughput [12184521.157op/s; 12194030.762op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.888µs; 58.893µs] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16979961.387op/s; 16981377.898op/s] or [-0.004%; +0.004%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.829µs; 6.837µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number/x371413321323331 throughput [146277312.630op/s; 146444854.887op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.610µs; 4.612µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ throughput [216807681.325op/s; 216917582.821op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.671µs; 73.713µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13566204.982op/s; 13573986.404op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.423µs; 65.461µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15276325.070op/s; 15285091.653op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.611µs; 4.613µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216778256.491op/s; 216882299.718op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.499µs; 62.537µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15990633.691op/s; 16000452.092op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.886µs; 58.891µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16980407.419op/s; 16982047.545op/s] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.831µs; 6.840µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146207153.433op/s; 146392393.031op/s] or [-0.063%; +0.063%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.663µs 273.011µs ± 0.749µs 272.790µs ± 0.428µs 273.371µs 274.461µs 275.030µs 275.603µs 1.03% 0.949 0.788 0.27% 0.053µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3628412.356op/s 3662877.163op/s ± 10021.775op/s 3665825.991op/s ± 5744.583op/s 3669191.223op/s 3675872.450op/s 3678065.125op/s 3681030.374op/s 0.41% -0.933 0.749 0.27% 708.646op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.793µs 25.887µs ± 0.060µs 25.877µs ± 0.038µs 25.925µs 25.990µs 26.047µs 26.144µs 1.03% 0.895 1.083 0.23% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 38249160.753op/s 38629550.134op/s ± 89846.651op/s 38644007.134op/s ± 57081.971op/s 38691937.688op/s 38753526.504op/s 38766865.149op/s 38770560.173op/s 0.33% -0.879 1.027 0.23% 6353.118op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.468µs 15.508µs ± 0.041µs 15.490µs ± 0.014µs 15.519µs 15.586µs 15.677µs 15.720µs 1.49% 2.163 6.190 0.26% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 63612186.187op/s 64483837.318op/s ± 170075.044op/s 64558994.905op/s ± 60279.048op/s 64597083.765op/s 64623229.876op/s 64639110.863op/s 64650260.945op/s 0.14% -2.136 6.007 0.26% 12026.122op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [272.908µs; 273.115µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3661488.241op/s; 3664266.084op/s] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.879µs; 25.895µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38617098.252op/s; 38642002.016op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.502µs; 15.514µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good throughput [64460266.553op/s; 64507408.084op/s] or [-0.037%; +0.037%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.727µs 2.758µs ± 0.021µs 2.753µs ± 0.007µs 2.761µs 2.815µs 2.829µs 2.833µs 2.91% 2.003 3.883 0.75% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.755µs; 2.761µs] or [-0.104%; +0.104%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.042ms 59.178ms ± 0.095ms 59.163ms ± 0.038ms 59.201ms 59.304ms 59.612ms 59.642ms 0.81% 2.730 9.332 0.16% 0.007ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.165ms; 59.191ms] or [-0.022%; +0.022%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a059912 1731688311 bob/live-debugger-dedup
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.620µs 37.227µs ± 0.999µs 36.783µs ± 0.074µs 36.863µs 39.365µs 39.394µs 40.505µs 10.12% 1.706 1.060 2.68% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.089µs; 37.366µs] or [-0.372%; +0.372%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.77665% with 95 lines in your changes missing coverage. Please review.

Project coverage is 70.57%. Comparing base (d04fad9) to head (a059912).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
- Coverage   70.58%   70.57%   -0.02%     
==========================================
  Files         295      296       +1     
  Lines       43096    43275     +179     
==========================================
+ Hits        30420    30542     +122     
- Misses      12676    12733      +57
Components Coverage Δ
crashtracker 37.14% <ø> (+0.03%) ⬆️
crashtracker-ffi 8.67% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.95% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.86% <ø> (+0.10%) ⬆️
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.03% <56.66%> (+0.67%) ⬆️
sidecar-ffi 0.00% <0.00%> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.18% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.14% <ø> (ø)

@bwoebi
clippy & add tests
fc9228a 
Signed-off-by: Bob Weinand <[email protected]>
ojung
ojung approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the rust code as I don't have experience with rust. Approving because the logic looks sound to me. Thanks!

@bwoebi bwoebi enabled auto-merge (squash) November 15, 2024 16:31
@bwoebi bwoebi merged commit 9ffc56b into main Nov 15, 2024
31 checks passed
@bwoebi bwoebi deleted the bob/live-debugger-dedup branch November 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

Assignees
No one assigned
Labels
sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwoebi @codecov-commenter @ojung