-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashtracking] Add explicit test for extra children #720
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
+ Coverage 71.56% 71.62% +0.05%
==========================================
Files 281 281
Lines 42419 42500 +81
==========================================
+ Hits 30356 30439 +83
+ Misses 12063 12061 -2
|
BenchmarksComparisonBenchmark execution time: 2024-11-11 04:52:55 Comparing candidate commit 637a057 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics. scenario:benching deserializing traces from msgpack to their internal representation
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some comments, but nothing that would block shipping this.
What does this PR do?
This patch adds a test without changing any functionality. During development of a recent crashtracking fix, I had a C-language repro for this situation which I'd test against the FFI. Now that the dust has settled a bit and we're doing some more feature work with crashtracking, it's time to add a regression test for this condition.
Motivation
This was the most significant defect end-users have experienced for crashtracking to date. We should check it explicitly.