Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracking] Add explicit test for extra children #720

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 8, 2024

What does this PR do?

This patch adds a test without changing any functionality. During development of a recent crashtracking fix, I had a C-language repro for this situation which I'd test against the FFI. Now that the dust has settled a bit and we're doing some more feature work with crashtracking, it's time to add a regression test for this condition.

Motivation

This was the most significant defect end-users have experienced for crashtracking to date. We should check it explicitly.

@sanchda sanchda requested a review from a team as a code owner November 8, 2024 04:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.62%. Comparing base (85c32c8) to head (637a057).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   71.56%   71.62%   +0.05%     
==========================================
  Files         281      281              
  Lines       42419    42500      +81     
==========================================
+ Hits        30356    30439      +83     
+ Misses      12063    12061       -2     
Components Coverage Δ
crashtracker 44.95% <93.82%> (+1.58%) ⬆️
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.21% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.75% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.59% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Nov 8, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-11 04:52:55

Comparing candidate commit 637a057 in PR branch sanchda/test_31138_fix with baseline commit 85c32c8 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟩 execution_time [-37.943ns; -27.604ns] or [-3.082%; -2.242%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.610µs 4.621µs ± 0.002µs 4.621µs ± 0.001µs 4.622µs 4.625µs 4.627µs 4.627µs 0.14% -0.021 2.966 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 216109850.914op/s 216397563.018op/s ± 99746.071op/s 216408883.623op/s ± 61391.160op/s 216466281.981op/s 216525478.682op/s 216550625.470op/s 216908563.819op/s 0.23% 0.028 2.990 0.05% 7053.112op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.213µs 91.304µs ± 0.313µs 91.351µs ± 0.188µs 91.501µs 91.755µs 92.020µs 92.108µs 0.83% -0.404 0.721 0.34% 0.022µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10856833.113op/s 10952524.912op/s ± 37630.330op/s 10946745.737op/s ± 22579.652op/s 10974053.544op/s 11019376.721op/s 11056510.567op/s 11084884.722op/s 1.26% 0.430 0.752 0.34% 2660.866op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 82.889µs 84.383µs ± 0.616µs 84.351µs ± 0.390µs 84.759µs 85.439µs 86.119µs 86.296µs 2.31% 0.445 0.439 0.73% 0.044µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11588059.858op/s 11851346.446op/s ± 86235.603op/s 11855238.219op/s ± 54773.450op/s 11905857.982op/s 11994533.437op/s 12026900.259op/s 12064362.461op/s 1.76% -0.396 0.384 0.73% 6097.778op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.610µs 4.621µs ± 0.003µs 4.620µs ± 0.001µs 4.622µs 4.624µs 4.626µs 4.642µs 0.48% 2.924 25.388 0.05% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 215403188.504op/s 216408915.772op/s ± 118919.188op/s 216429736.086op/s ± 60120.417op/s 216476647.588op/s 216532721.343op/s 216561216.935op/s 216899268.173op/s 0.22% -2.893 25.102 0.05% 8408.856op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 79.047µs 80.307µs ± 0.441µs 80.351µs ± 0.340µs 80.662µs 80.901µs 80.977µs 81.536µs 1.48% -0.389 -0.262 0.55% 0.031µs 1 200
credit_card/is_card_number/378282246310005 throughput 12264448.993op/s 12452576.682op/s ± 68597.934op/s 12445379.718op/s ± 52698.859op/s 12502491.121op/s 12572390.553op/s 12613788.932op/s 12650725.808op/s 1.65% 0.415 -0.236 0.55% 4850.606op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.862µs 59.009µs ± 0.163µs 58.929µs ± 0.056µs 59.098µs 59.343µs 59.559µs 59.688µs 1.29% 1.572 2.438 0.28% 0.012µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16753730.218op/s 16946661.483op/s ± 46603.403op/s 16969498.180op/s ± 16269.445op/s 16980491.538op/s 16986518.310op/s 16988047.855op/s 16988792.494op/s 0.11% -1.556 2.356 0.27% 3295.358op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.817µs 6.827µs ± 0.027µs 6.822µs ± 0.002µs 6.823µs 6.842µs 6.957µs 7.056µs 3.43% 5.917 38.989 0.40% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 141718670.458op/s 146476053.804op/s ± 574526.545op/s 146583362.789op/s ± 41002.033op/s 146633139.089op/s 146660156.333op/s 146678132.802op/s 146701179.804op/s 0.08% -5.847 38.010 0.39% 40625.162op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.607µs 4.620µs ± 0.002µs 4.620µs ± 0.001µs 4.621µs 4.623µs 4.625µs 4.636µs 0.35% 0.989 13.038 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215704546.344op/s 216450283.229op/s ± 110197.848op/s 216458883.635op/s ± 59195.628op/s 216515383.421op/s 216588805.743op/s 216611098.318op/s 217041975.517op/s 0.27% -0.968 12.968 0.05% 7792.165op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.346µs 73.756µs ± 0.144µs 73.755µs ± 0.089µs 73.836µs 74.001µs 74.121µs 74.245µs 0.66% 0.265 0.564 0.19% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13468887.118op/s 13558197.228op/s ± 26400.965op/s 13558437.964op/s ± 16399.717op/s 13575164.576op/s 13600956.966op/s 13615087.489op/s 13633986.802op/s 0.56% -0.251 0.551 0.19% 1866.830op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 66.304µs 66.597µs ± 0.114µs 66.585µs ± 0.072µs 66.666µs 66.768µs 66.958µs 67.176µs 0.89% 1.124 3.580 0.17% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14886264.503op/s 15015649.674op/s ± 25647.563op/s 15018420.690op/s ± 16230.447op/s 15032713.201op/s 15048081.948op/s 15061521.763op/s 15082046.332op/s 0.42% -1.102 3.485 0.17% 1813.557op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.606µs 4.621µs ± 0.003µs 4.621µs ± 0.001µs 4.622µs 4.624µs 4.625µs 4.652µs 0.66% 4.947 61.132 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 214981786.652op/s 216399672.797op/s ± 136303.342op/s 216401179.387op/s ± 57125.959op/s 216451017.522op/s 216532191.820op/s 216562040.215op/s 217124740.672op/s 0.33% -4.874 60.420 0.06% 9638.102op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.140µs 62.272µs ± 0.089µs 62.262µs ± 0.062µs 62.325µs 62.449µs 62.534µs 62.564µs 0.49% 0.858 0.584 0.14% 0.006µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15983574.048op/s 16058562.166op/s ± 22806.567op/s 16061254.633op/s ± 15904.294op/s 16076574.422op/s 16087280.592op/s 16090293.676op/s 16092782.387op/s 0.20% -0.850 0.562 0.14% 1612.668op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.864µs 59.004µs ± 0.153µs 58.921µs ± 0.045µs 59.091µs 59.276µs 59.497µs 59.572µs 1.10% 1.339 1.197 0.26% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16786408.065op/s 16948102.367op/s ± 43933.872op/s 16971869.128op/s ± 13100.874op/s 16980162.928op/s 16985884.136op/s 16987528.165op/s 16988364.669op/s 0.10% -1.328 1.150 0.26% 3106.594op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.817µs 6.842µs ± 0.058µs 6.822µs ± 0.002µs 6.824µs 6.945µs 7.063µs 7.223µs 5.87% 3.631 15.063 0.84% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 138452630.359op/s 146161877.624op/s ± 1197164.680op/s 146577441.735op/s ± 50136.623op/s 146628053.613op/s 146656230.199op/s 146673241.878op/s 146687352.318op/s 0.07% -3.537 14.137 0.82% 84652.326op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.621µs; 4.621µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ throughput [216383739.172op/s; 216411386.864op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.261µs; 91.348µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10947309.710op/s; 10957740.114op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.298µs; 84.468µs] or [-0.101%; +0.101%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11839395.020op/s; 11863297.871op/s] or [-0.101%; +0.101%] None None None
credit_card/is_card_number/37828224631 execution_time [4.621µs; 4.621µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631 throughput [216392434.717op/s; 216425396.828op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.246µs; 80.368µs] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/378282246310005 throughput [12443069.668op/s; 12462083.696op/s] or [-0.076%; +0.076%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.987µs; 59.032µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16940202.700op/s; 16953120.267op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.823µs; 6.831µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number/x371413321323331 throughput [146396429.950op/s; 146555677.657op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.620µs; 4.620µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [216435010.867op/s; 216465555.591op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.736µs; 73.776µs] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13554538.308op/s; 13561856.148op/s] or [-0.027%; +0.027%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.582µs; 66.613µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15012095.168op/s; 15019204.179op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.621µs; 4.621µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216380782.465op/s; 216418563.130op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.260µs; 62.284µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16055401.395op/s; 16061722.936op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.983µs; 59.025µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16942013.555op/s; 16954191.179op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.834µs; 6.850µs] or [-0.117%; +0.117%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [145995962.113op/s; 146327793.134op/s] or [-0.114%; +0.114%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 297.064ns 307.209ns ± 13.397ns 300.687ns ± 2.911ns 309.046ns 340.983ns 347.804ns 351.062ns 16.75% 1.753 2.186 4.35% 0.947ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.352ns; 309.066ns] or [-0.604%; +0.604%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 140.323µs 141.270µs ± 0.404µs 141.239µs ± 0.184µs 141.428µs 141.770µs 143.207µs 143.403µs 1.53% 1.899 8.465 0.29% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [141.214µs; 141.326µs] or [-0.040%; +0.040%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.228µs 67.419µs ± 0.118µs 67.408µs ± 0.040µs 67.449µs 67.518µs 67.561µs 68.855µs 2.15% 9.051 107.876 0.17% 0.008µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.402µs; 67.435µs] or [-0.024%; +0.024%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.548µs 273.721µs ± 0.901µs 273.655µs ± 0.651µs 274.327µs 275.251µs 275.934µs 276.423µs 1.01% 0.282 -0.229 0.33% 0.064µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3617637.866op/s 3653397.348op/s ± 12020.325op/s 3654233.991op/s ± 8667.397op/s 3662074.171op/s 3670088.908op/s 3678028.920op/s 3682591.091op/s 0.78% -0.266 -0.242 0.33% 849.965op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.802µs 25.901µs ± 0.069µs 25.882µs ± 0.043µs 25.941µs 26.021µs 26.064µs 26.222µs 1.31% 1.116 1.797 0.27% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 38136324.172op/s 38608671.561op/s ± 102988.568op/s 38637560.186op/s ± 63517.513op/s 38682957.384op/s 38731635.974op/s 38754822.196op/s 38757415.525op/s 0.31% -1.096 1.702 0.27% 7282.392op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.462µs 15.522µs ± 0.043µs 15.512µs ± 0.021µs 15.535µs 15.618µs 15.645µs 15.785µs 1.75% 2.101 7.227 0.27% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 63352497.020op/s 64423581.534op/s ± 175930.243op/s 64464264.049op/s ± 85992.641op/s 64537279.907op/s 64602167.783op/s 64644986.533op/s 64674123.937op/s 0.33% -2.062 6.932 0.27% 12440.147op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [273.596µs; 273.846µs] or [-0.046%; +0.046%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3651731.446op/s; 3655063.249op/s] or [-0.046%; +0.046%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [25.891µs; 25.911µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [38594398.336op/s; 38622944.786op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.516µs; 15.528µs] or [-0.038%; +0.038%] None None None
normalization/normalize_name/normalize_name/good throughput [64399199.295op/s; 64447963.774op/s] or [-0.038%; +0.038%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.374µs 3.300µs ± 1.431µs 3.153µs ± 0.025µs 3.173µs 3.211µs 14.059µs 15.178µs 381.44% 7.559 57.421 43.26% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.102µs; 3.498µs] or [-6.011%; +6.011%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.153µs 38.517µs ± 0.646µs 38.216µs ± 0.033µs 38.283µs 39.844µs 39.896µs 41.326µs 8.14% 1.815 1.898 1.67% 0.046µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.428µs; 38.607µs] or [-0.233%; +0.233%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.656µs 2.712µs ± 0.017µs 2.712µs ± 0.004µs 2.719µs 2.740µs 2.745µs 2.748µs 1.33% -1.446 3.547 0.64% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.710µs; 2.715µs] or [-0.088%; +0.088%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.629µs 25.490µs ± 11.174µs 19.365µs ± 0.288µs 35.759µs 44.471µs 53.164µs 95.065µs 390.91% 2.339 8.101 43.73% 0.790µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.941µs; 27.039µs] or [-6.076%; +6.076%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.129µs 1.198µs ± 0.025µs 1.200µs ± 0.017µs 1.219µs 1.222µs 1.222µs 1.223µs 1.91% -1.364 1.051 2.10% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.195µs; 1.202µs] or [-0.292%; +0.292%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.105ms 9.133ms ± 0.012ms 9.132ms ± 0.007ms 9.140ms 9.155ms 9.169ms 9.179ms 0.51% 0.555 1.131 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.131ms; 9.135ms] or [-0.018%; +0.018%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 637a057 1731300128 sanchda/test_31138_fix
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 505.817µs 507.112µs ± 0.534µs 507.161µs ± 0.356µs 507.493µs 507.854µs 508.757µs 508.814µs 0.33% 0.261 0.501 0.11% 0.038µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1965356.090op/s 1971955.066op/s ± 2075.409op/s 1971759.762op/s ± 1382.530op/s 1973347.506op/s 1975134.394op/s 1976339.355op/s 1976999.357op/s 0.27% -0.253 0.487 0.10% 146.754op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 471.655µs 472.404µs ± 0.289µs 472.389µs ± 0.187µs 472.578µs 472.919µs 473.063µs 473.364µs 0.21% 0.261 0.187 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2112537.543op/s 2116833.562op/s ± 1292.924op/s 2116898.594op/s ± 836.439op/s 2117733.204op/s 2118779.220op/s 2119787.477op/s 2120194.969op/s 0.16% -0.257 0.184 0.06% 91.424op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.750µs 180.111µs ± 0.161µs 180.094µs ± 0.097µs 180.210µs 180.410µs 180.474µs 180.504µs 0.23% 0.244 -0.279 0.09% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5540056.909op/s 5552142.713op/s ± 4958.963op/s 5552661.100op/s ± 3005.118op/s 5555344.220op/s 5559904.184op/s 5562833.091op/s 5563274.033op/s 0.19% -0.239 -0.281 0.09% 350.652op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.906µs 45.139µs ± 0.070µs 45.138µs ± 0.039µs 45.176µs 45.252µs 45.286µs 45.420µs 0.63% 0.022 1.430 0.15% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22016660.522op/s 22154020.442op/s ± 34200.709op/s 22154350.304op/s ± 19199.564op/s 22173784.124op/s 22213471.095op/s 22243353.479op/s 22268601.982op/s 0.52% -0.006 1.420 0.15% 2418.355op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.970µs 49.118µs ± 0.078µs 49.109µs ± 0.050µs 49.161µs 49.245µs 49.325µs 49.400µs 0.59% 0.630 0.490 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20243016.219op/s 20359172.483op/s ± 32123.123op/s 20362671.152op/s ± 20540.446op/s 20382037.319op/s 20406824.450op/s 20416494.570op/s 20420827.610op/s 0.29% -0.620 0.467 0.16% 2271.448op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.038µs; 507.185µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1971667.434op/s; 1972242.698op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [472.364µs; 472.444µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2116654.375op/s; 2117012.749op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.088µs; 180.133µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5551455.448op/s; 5552829.977op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.129µs; 45.148µs] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22149280.553op/s; 22158760.331op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.107µs; 49.129µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20354720.527op/s; 20363624.439op/s] or [-0.022%; +0.022%] None None None

Baseline

Omitted due to size.

Copy link
Contributor

@danielsn danielsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some comments, but nothing that would block shipping this.

crashtracker/src/collector/api.rs Outdated Show resolved Hide resolved
crashtracker/src/collector/api.rs Outdated Show resolved Hide resolved
crashtracker/src/collector/api.rs Show resolved Hide resolved
crashtracker/src/collector/api.rs Show resolved Hide resolved
@sanchda sanchda enabled auto-merge (squash) November 11, 2024 05:04
@sanchda sanchda merged commit 1fc6b11 into main Nov 11, 2024
32 checks passed
@sanchda sanchda deleted the sanchda/test_31138_fix branch November 11, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants