Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] RFC to mitigate hangs #716

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Conversation

danielsn
Copy link
Contributor

@danielsn danielsn commented Nov 6, 2024

What does this PR do?

Adds an RFC mitigating an open issue from #696

Motivation

We want to limit the potential impact of crashtracking on users.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

This is a documentation only change

@danielsn danielsn requested a review from a team as a code owner November 6, 2024 20:28
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but they are very much for discussion and in no way impact the substance of this RFC.

Looks pretty good to me.

docs/RFCs/0004-crashtracker-prevent-hangs.md Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Outdated Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Outdated Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Outdated Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Show resolved Hide resolved
docs/RFCs/0004-crashtracker-prevent-hangs.md Outdated Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-11-07 21:42:46

Comparing candidate commit 300ce5c in PR branch dsn/crashtracker-hang-rfc with baseline commit 16b19c9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.200µs 25.049µs ± 10.427µs 19.996µs ± 0.352µs 28.077µs 44.505µs 46.245µs 97.008µs 385.14% 3.123 14.915 41.52% 0.737µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.604µs; 26.494µs] or [-5.769%; +5.769%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.716µs 2.768µs ± 0.025µs 2.764µs ± 0.005µs 2.770µs 2.815µs 2.883µs 2.889µs 4.52% 1.950 7.013 0.90% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.764µs; 2.771µs] or [-0.125%; +0.125%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.386µs 3.282µs ± 1.420µs 3.131µs ± 0.023µs 3.151µs 3.190µs 13.995µs 15.023µs 379.80% 7.561 57.396 43.15% 0.100µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.085µs; 3.479µs] or [-5.995%; +5.995%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 293.567ns 304.553ns ± 12.967ns 299.462ns ± 4.278ns 307.100ns 338.265ns 340.762ns 343.070ns 14.56% 1.681 1.701 4.25% 0.917ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [302.756ns; 306.350ns] or [-0.590%; +0.590%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.752µs 68.021µs ± 0.134µs 67.997µs ± 0.045µs 68.050µs 68.200µs 68.251µs 69.433µs 2.11% 6.133 60.237 0.20% 0.009µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.003µs; 68.040µs] or [-0.027%; +0.027%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 271.836µs 272.962µs ± 0.590µs 272.856µs ± 0.360µs 273.320µs 274.078µs 274.485µs 275.590µs 1.00% 0.853 1.507 0.22% 0.042µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3628580.441op/s 3663530.517op/s ± 7904.200op/s 3664933.683op/s ± 4827.267op/s 3668412.896op/s 3674678.894op/s 3677698.169op/s 3678693.132op/s 0.38% -0.835 1.445 0.22% 558.911op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 25.866µs 26.296µs ± 0.308µs 26.164µs ± 0.254µs 26.579µs 26.770µs 26.871µs 26.932µs 2.93% 0.222 -1.511 1.17% 0.022µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 37130821.601op/s 38033126.856op/s ± 444253.063op/s 38220287.133op/s ± 371915.782op/s 38443539.652op/s 38580269.369op/s 38630969.477op/s 38661376.923op/s 1.15% -0.207 -1.528 1.17% 31413.435op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.644µs 15.743µs ± 0.104µs 15.728µs ± 0.023µs 15.760µs 15.789µs 15.830µs 17.129µs 8.91% 12.075 159.154 0.66% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 58380094.644op/s 63520944.683op/s ± 387389.380op/s 63581826.282op/s ± 92843.344op/s 63635342.749op/s 63720189.770op/s 63825141.060op/s 63921377.780op/s 0.53% -11.767 153.675 0.61% 27392.566op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [272.880µs; 273.044µs] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3662435.071op/s; 3664625.963op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [26.254µs; 26.339µs] or [-0.162%; +0.162%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [37971557.654op/s; 38094696.057op/s] or [-0.162%; +0.162%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.729µs; 15.758µs] or [-0.091%; +0.091%] None None None
normalization/normalize_name/normalize_name/good throughput [63467256.241op/s; 63574633.126op/s] or [-0.085%; +0.085%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.603µs 38.079µs ± 0.863µs 37.689µs ± 0.040µs 37.754µs 39.905µs 39.977µs 41.153µs 9.19% 1.753 1.258 2.26% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.960µs; 38.199µs] or [-0.314%; +0.314%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 506.331µs 507.316µs ± 0.413µs 507.298µs ± 0.252µs 507.540µs 507.999µs 508.462µs 508.747µs 0.29% 0.422 0.563 0.08% 0.029µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1965615.147op/s 1971157.976op/s ± 1603.741op/s 1971228.300op/s ± 978.404op/s 1972216.344op/s 1973676.553op/s 1974475.641op/s 1974990.808op/s 0.19% -0.417 0.554 0.08% 113.402op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 467.754µs 468.488µs ± 0.415µs 468.461µs ± 0.201µs 468.645µs 468.972µs 469.352µs 472.490µs 0.86% 4.560 41.504 0.09% 0.029µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2116445.730op/s 2134529.304op/s ± 1884.415op/s 2134650.615op/s ± 916.657op/s 2135575.073op/s 2136776.119op/s 2137434.277op/s 2137876.614op/s 0.15% -4.501 40.752 0.09% 133.248op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 179.631µs 180.130µs ± 0.205µs 180.134µs ± 0.140µs 180.255µs 180.455µs 180.641µs 180.722µs 0.33% 0.126 -0.038 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5533361.378op/s 5551549.915op/s ± 6317.447op/s 5551425.837op/s ± 4322.149op/s 5555921.433op/s 5561461.707op/s 5565144.226op/s 5566966.328op/s 0.28% -0.119 -0.042 0.11% 446.711op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.750µs 45.009µs ± 0.072µs 45.004µs ± 0.047µs 45.055µs 45.123µs 45.172µs 45.250µs 0.55% -0.005 0.664 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22099596.455op/s 22217600.521op/s ± 35728.395op/s 22220101.772op/s ± 23034.477op/s 22239990.562op/s 22271755.752op/s 22297929.933op/s 22346531.628op/s 0.57% 0.018 0.669 0.16% 2526.379op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.993µs 49.155µs ± 0.069µs 49.149µs ± 0.047µs 49.199µs 49.269µs 49.308µs 49.354µs 0.42% 0.330 -0.346 0.14% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20261598.693op/s 20343960.246op/s ± 28705.661op/s 20346371.847op/s ± 19476.130op/s 20365139.770op/s 20386188.284op/s 20398340.721op/s 20411280.090op/s 0.32% -0.324 -0.352 0.14% 2029.797op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [507.259µs; 507.374µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1970935.713op/s; 1971380.240op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [468.430µs; 468.545µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2134268.142op/s; 2134790.466op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [180.102µs; 180.159µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5550674.377op/s; 5552425.452op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.999µs; 45.020µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22212648.909op/s; 22222552.133op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [49.145µs; 49.164µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20339981.917op/s; 20347938.575op/s] or [-0.020%; +0.020%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.605µs 4.623µs ± 0.003µs 4.622µs ± 0.001µs 4.624µs 4.627µs 4.630µs 4.631µs 0.19% -0.584 8.780 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 215927658.248op/s 216328000.093op/s ± 129762.600op/s 216337564.981op/s ± 67033.617op/s 216405231.597op/s 216472607.077op/s 216519092.863op/s 217174531.248op/s 0.39% 0.603 8.889 0.06% 9175.601op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.094µs 90.945µs ± 0.335µs 90.924µs ± 0.244µs 91.189µs 91.492µs 91.630µs 91.889µs 1.06% 0.030 -0.401 0.37% 0.024µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10882649.130op/s 10995800.935op/s ± 40511.988op/s 10998168.807op/s ± 29640.023op/s 11025443.416op/s 11064354.991op/s 11081270.019op/s 11099565.321op/s 0.92% -0.012 -0.402 0.37% 2864.630op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 82.907µs 84.472µs ± 0.691µs 84.417µs ± 0.481µs 84.893µs 85.707µs 86.130µs 87.095µs 3.17% 0.460 0.267 0.82% 0.049µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11481774.083op/s 11839027.109op/s ± 96529.236op/s 11845989.986op/s ± 67685.127op/s 11913778.882op/s 11978775.074op/s 12018216.479op/s 12061645.346op/s 1.82% -0.410 0.165 0.81% 6825.648op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.608µs 4.623µs ± 0.004µs 4.622µs ± 0.002µs 4.624µs 4.626µs 4.630µs 4.665µs 0.92% 6.083 65.030 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 214370274.200op/s 216327429.343op/s ± 183417.863op/s 216346058.963op/s ± 75548.443op/s 216419556.852op/s 216474713.598op/s 216513636.682op/s 217024178.498op/s 0.31% -6.006 64.047 0.08% 12969.602op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 78.954µs 80.289µs ± 0.417µs 80.312µs ± 0.297µs 80.613µs 80.885µs 80.920µs 80.955µs 0.80% -0.622 0.139 0.52% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 12352518.343op/s 12455283.045op/s ± 64948.620op/s 12451368.692op/s ± 45903.745op/s 12496793.014op/s 12570694.215op/s 12623711.725op/s 12665618.156op/s 1.72% 0.650 0.198 0.52% 4592.561op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.855µs 59.040µs ± 0.185µs 58.949µs ± 0.077µs 59.201µs 59.402µs 59.514µs 59.559µs 1.04% 0.901 -0.352 0.31% 0.013µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16790116.824op/s 16937807.769op/s ± 53051.647op/s 16963928.978op/s ± 22215.424op/s 16981245.066op/s 16987802.163op/s 16989732.408op/s 16990998.169op/s 0.16% -0.893 -0.375 0.31% 3751.318op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.819µs 6.832µs ± 0.041µs 6.823µs ± 0.002µs 6.825µs 6.901µs 7.029µs 7.183µs 5.27% 5.412 33.998 0.60% 0.003µs 1 200
credit_card/is_card_number/x371413321323331 throughput 139219170.385op/s 146366835.549op/s ± 852294.534op/s 146554245.765op/s ± 38624.111op/s 146623107.802op/s 146643112.342op/s 146650477.681op/s 146654262.077op/s 0.07% -5.297 32.361 0.58% 60266.324op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.609µs 4.621µs ± 0.002µs 4.621µs ± 0.001µs 4.622µs 4.624µs 4.625µs 4.627µs 0.12% -0.917 6.391 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216143795.026op/s 216397051.240op/s ± 94527.519op/s 216402099.693op/s ± 59775.784op/s 216454674.396op/s 216530401.951op/s 216555627.747op/s 216987375.344op/s 0.27% 0.926 6.454 0.04% 6684.105op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.354µs 73.788µs ± 0.169µs 73.776µs ± 0.100µs 73.875µs 74.069µs 74.202µs 74.434µs 0.89% 0.436 1.024 0.23% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13434792.358op/s 13552423.904op/s ± 31062.310op/s 13554452.972op/s ± 18480.563op/s 13572924.391op/s 13599950.768op/s 13625078.579op/s 13632465.717op/s 0.58% -0.417 0.992 0.23% 2196.437op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 66.010µs 66.623µs ± 0.121µs 66.614µs ± 0.064µs 66.685µs 66.780µs 67.077µs 67.168µs 0.83% 0.492 6.959 0.18% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14887937.704op/s 15009856.341op/s ± 27204.883op/s 15011938.468op/s ± 14531.006op/s 15025231.446op/s 15041932.201op/s 15075474.044op/s 15149254.772op/s 0.91% -0.444 6.964 0.18% 1923.676op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.608µs 4.621µs ± 0.004µs 4.621µs ± 0.001µs 4.622µs 4.624µs 4.626µs 4.662µs 0.88% 7.516 87.534 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 214497388.036op/s 216389311.361op/s ± 164777.804op/s 216394518.492op/s ± 52731.510op/s 216450059.569op/s 216530302.334op/s 216571514.731op/s 217031053.284op/s 0.29% -7.441 86.515 0.08% 11651.550op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.136µs 62.311µs ± 0.104µs 62.297µs ± 0.077µs 62.379µs 62.482µs 62.545µs 62.804µs 0.81% 0.876 1.543 0.17% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15922582.623op/s 16048676.451op/s ± 26748.426op/s 16052056.527op/s ± 19733.228op/s 16070079.120op/s 16085296.190op/s 16087738.634op/s 16093680.012op/s 0.26% -0.862 1.480 0.17% 1891.399op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.865µs 59.044µs ± 0.184µs 58.945µs ± 0.073µs 59.195µs 59.382µs 59.529µs 59.683µs 1.25% 1.028 0.337 0.31% 0.013µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16755146.984op/s 16936765.967op/s ± 52708.988op/s 16964872.546op/s ± 20932.416op/s 16979889.868op/s 16986052.923op/s 16987964.146op/s 16987992.887op/s 0.14% -1.016 0.294 0.31% 3727.088op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.818µs 6.834µs ± 0.044µs 6.822µs ± 0.002µs 6.823µs 6.914µs 7.023µs 7.195µs 5.47% 4.718 27.720 0.64% 0.003µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 138990410.420op/s 146337055.240op/s ± 905424.776op/s 146590218.586op/s ± 44807.436op/s 146640944.026op/s 146670761.917op/s 146677434.557op/s 146680902.147op/s 0.06% -4.583 25.914 0.62% 64023.200op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.622µs; 4.623µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [216310016.245op/s; 216345983.941op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [90.899µs; 90.991µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10990186.363op/s; 11001415.507op/s] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.376µs; 84.568µs] or [-0.113%; +0.113%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11825649.085op/s; 11852405.132op/s] or [-0.113%; +0.113%] None None None
credit_card/is_card_number/37828224631 execution_time [4.622µs; 4.623µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [216302009.391op/s; 216352849.295op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [80.232µs; 80.347µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/378282246310005 throughput [12446281.791op/s; 12464284.299op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.014µs; 59.066µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16930455.321op/s; 16945160.217op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.827µs; 6.838µs] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/x371413321323331 throughput [146248715.724op/s; 146484955.375op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.621µs; 4.621µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ throughput [216383950.635op/s; 216410151.845op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.764µs; 73.811µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13548118.967op/s; 13556728.842op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.606µs; 66.640µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15006086.006op/s; 15013626.677op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.621µs; 4.622µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216366474.742op/s; 216412147.979op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.296µs; 62.325µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16044969.376op/s; 16052383.526op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.018µs; 59.069µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16929461.008op/s; 16944070.926op/s] or [-0.043%; +0.043%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.828µs; 6.840µs] or [-0.088%; +0.088%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146211572.074op/s; 146462538.406op/s] or [-0.086%; +0.086%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.027µs 142.794µs ± 0.464µs 142.677µs ± 0.266µs 143.031µs 143.483µs 143.805µs 146.396µs 2.61% 2.693 16.918 0.32% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.730µs; 142.858µs] or [-0.045%; +0.045%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.131µs 1.197µs ± 0.026µs 1.196µs ± 0.019µs 1.219µs 1.224µs 1.226µs 1.233µs 3.10% -1.072 0.434 2.16% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.193µs; 1.201µs] or [-0.300%; +0.300%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 300ce5c 1731015123 dsn/crashtracker-hang-rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.193ms 9.214ms ± 0.028ms 9.211ms ± 0.006ms 9.218ms 9.233ms 9.254ms 9.571ms 3.92% 10.918 137.817 0.30% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.211ms; 9.218ms] or [-0.042%; +0.042%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (16b19c9) to head (300ce5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   71.59%   71.44%   -0.16%     
==========================================
  Files         281      281              
  Lines       42414    42414              
==========================================
- Hits        30368    30304      -64     
- Misses      12046    12110      +64     
Components Coverage Δ
crashtracker 43.37% <ø> (ø)
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 92.19% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.75% <ø> (-0.11%) ⬇️
profiling 83.49% <ø> (-0.81%) ⬇️
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.55% <ø> (ø)

@danielsn danielsn merged commit 6943925 into main Nov 7, 2024
32 checks passed
@danielsn danielsn deleted the dsn/crashtracker-hang-rfc branch November 7, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants