-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[crashtracker] RFC to mitigate hangs #716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, but they are very much for discussion and in no way impact the substance of this RFC.
Looks pretty good to me.
Co-authored-by: David Sanchez <[email protected]>
BenchmarksComparisonBenchmark execution time: 2024-11-07 21:42:46 Comparing candidate commit 300ce5c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 71.59% 71.44% -0.16%
==========================================
Files 281 281
Lines 42414 42414
==========================================
- Hits 30368 30304 -64
- Misses 12046 12110 +64
|
What does this PR do?
Adds an RFC mitigating an open issue from #696
Motivation
We want to limit the potential impact of crashtracking on users.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
This is a documentation only change