-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run clippy on windows in CI #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Clippy is home" ;) |
VianneyRuhlmann
force-pushed
the
vianney/actions/run-clippy-on-windows
branch
from
June 13, 2024 13:14
0fda14b
to
ce45832
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=======================================
Coverage 69.67% 69.67%
=======================================
Files 199 199
Lines 26606 26606
=======================================
Hits 18539 18539
Misses 8067 8067
|
VianneyRuhlmann
force-pushed
the
vianney/actions/run-clippy-on-windows
branch
2 times, most recently
from
June 13, 2024 13:22
28837c6
to
015bf2b
Compare
danielsn
approved these changes
Jun 13, 2024
VianneyRuhlmann
force-pushed
the
vianney/actions/run-clippy-on-windows
branch
from
June 14, 2024 07:51
83eb562
to
9e23d45
Compare
VianneyRuhlmann
force-pushed
the
vianney/actions/run-clippy-on-windows
branch
from
June 14, 2024 08:36
813ba2b
to
ffcea0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run clippy on windows, it is currently done in gitlab. This allows us to remove the gitlab job to run clippy only once.
Motivation
We need to run clippy on windows to check windows specific code