Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to manually build the mini agent for testing #261

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thedavl
Copy link
Contributor

@thedavl thedavl commented Sep 22, 2023

What does this PR do?

Add a manually dispatched workflow that builds the serverless trace mini agent off of a given branch. Defaults to main. Used for testing (build linux + windows binaries on mac).

Motivation

Make testing less painful

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Manually tested

For Reviewers

  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@thedavl thedavl marked this pull request as ready for review September 22, 2023 19:48
@thedavl thedavl requested a review from a team as a code owner September 22, 2023 19:48
@morrisonlevi
Copy link
Contributor

morrisonlevi commented Sep 25, 2023

@DataDog/security-design-and-guidance , can we get a check here?

If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from DataDog/security-design-and-guidance.

I'm not 100% sure if it's necessary, but this is the first time we've had a PR maybe need such a review in libdatadog, and I'd rather be safe than sorry.

Edit: feel free to reach out to us on #libdatadog on company slack if there is anything you do not wish to discuss in public.

@chuckfw chuckfw assigned chuckfw and Zenithar and unassigned chuckfw Sep 26, 2023
@Zenithar Zenithar requested a review from a team September 28, 2023 13:05
@Zenithar Zenithar assigned morrisonlevi and unassigned Zenithar Sep 28, 2023
@Zenithar Zenithar requested a review from a team September 28, 2023 13:05
Copy link

@Zenithar Zenithar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Linked to review https://datadoghq.atlassian.net/browse/SDG-910

As the PR concerns GHA, I would recommend to get @DataDog/software-integrity-and-trust approval as part of their CICD security expertise.

Copy link

@cedricvanrompay-datadog cedricvanrompay-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the delay

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To override this behavior, add the keep-open label or update the PR.

@github-actions github-actions bot added the stale Used by actions/stale to identify PRs that have been inactive for 90+ days label Oct 23, 2024
for file in target/release/binaries/*/*
do
chmod +x "$file"
upx "$file" --lzma

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Using UPX for processes that are started repetitively can add a delay to the FaaS platform warmup. Also UPX packed executable can trigger AV and malware analysis pipelines.

Prefer to ship your binary stripped, and compressed by the archiver, like you do in the next step than artificially reduce the binary size which will run additional code to unpack from memory. To reduce your Rust binary size, I advise you to have a look to this repo - https://github.com/johnthagen/min-sized-rust

@github-actions github-actions bot removed the stale Used by actions/stale to identify PRs that have been inactive for 90+ days label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants