Apply go-oidc patch to remove cache-control of oidc tokens #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the dependency on github.com/pquerna/cachecontrol and brings the package more inline with the strategy from the OpenID Spec for rotation. https://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys
amardomingo
changed the base branch from
release-1.28-dd-v1.28.11-dd.2
to
release-1.28-dd-v1.28.11-dd.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on github.com/pquerna/cachecontrol and brings the package more inline with the strategy from the OpenID Spec for rotation.
https://openid.net/specs/openid-connect-core-1_0.html#RotateSigKeys
Apply fromat-patch from coreos/go-oidc#259
This refreshes the keys from the oidc remote if the kid of the token doesn't match, and should help with oidc keys being rotated earlier than expected.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: