Upgrade GitHub Actions mac runner. #19163

nubtron · 2024-11-28T16:43:52Z

What does this PR do?

This PR upgrades the macos runner in GitHub Actions from macos-12 to macos-13.
It has to be done because the macos-12 runner will be discontinued on December 3rd 2024.

The "build-ddev" and and "Build dependencies" actions are affected. Ddev also will generate Mac tests on the macos-13 runner from now on, but we aren't currently running any tests on Mac.

build-ddev runs: https://github.com/DataDog/integrations-core/actions/runs/12086874020/job/33707148773?pr=19163
And also "Build dependencies": https://github.com/DataDog/integrations-core/actions/runs/12086874011/job/33707111592?pr=19163

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

codecov · 2024-11-28T16:46:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (f527ddf) to head (776eade).
Report is 1 commits behind head on master.

Additional details and impacted files

Flag	Coverage Δ
active_directory	`86.36% <ø> (ø)`
activemq	`52.80% <ø> (ø)`
activemq_xml	`82.20% <ø> (ø)`
amazon_msk	`89.19% <ø> (ø)`
ambari	`85.75% <ø> (ø)`
apache	`95.08% <ø> (ø)`
appgate_sdp	`93.93% <ø> (ø)`
arangodb	`98.23% <ø> (ø)`
argo_rollouts	`90.00% <ø> (ø)`
argo_workflows	`87.87% <ø> (ø)`
argocd	`87.23% <ø> (ø)`
aspdotnet	`100.00% <ø> (ø)`
avi_vantage	`91.35% <ø> (ø)`
aws_neuron	`92.42% <ø> (ø)`
azure_iot_edge	`82.08% <ø> (ø)`
boundary	`100.00% <ø> (ø)`
btrfs	`83.33% <ø> (ø)`
cacti	`87.90% <ø> (ø)`
calico	`84.61% <ø> (ø)`
cassandra	`66.66% <ø> (ø)`
cert_manager	`77.41% <ø> (ø)`
cisco_aci	`89.59% <ø> (ø)`
citrix_hypervisor	`87.50% <ø> (ø)`
cloud_foundry_api	`96.11% <ø> (ø)`
cloudera	`99.51% <ø> (ø)`
cockroachdb	`92.98% <ø> (ø)`
consul	`91.92% <ø> (ø)`
coredns	`95.65% <ø> (ø)`
couch	`95.17% <ø> (ø)`
crio	`89.79% <ø> (ø)`
datadog_checks_base	`89.59% <ø> (+0.29%)`	⬆️
datadog_checks_dev	`77.63% <ø> (ø)`
datadog_checks_downloader	`81.35% <ø> (+3.23%)`	⬆️
datadog_cluster_agent	`90.19% <ø> (ø)`
dcgm	`93.54% <ø> (ø)`
ddev	`87.46% <ø> (ø)`
directory	`96.46% <ø> (ø)`
disk	`89.44% <ø> (ø)`
dns_check	`93.81% <ø> (ø)`
druid	`97.70% <ø> (ø)`
ecs_fargate	`83.71% <ø> (ø)`
eks_fargate	`94.05% <ø> (ø)`
envoy	`92.97% <ø> (+3.02%)`	⬆️
esxi	`93.92% <ø> (ø)`
etcd	`95.56% <ø> (ø)`
external_dns	`89.28% <ø> (ø)`
fluentd	`84.21% <ø> (ø)`
fluxcd	`88.31% <ø> (ø)`
fly_io	`97.13% <ø> (ø)`
foundationdb	`83.83% <ø> (ø)`
gitlab_runner	`92.76% <ø> (ø)`
glusterfs	`80.00% <ø> (ø)`
go_expvar	`92.66% <ø> (ø)`
gunicorn	`92.16% <ø> (ø)`
hazelcast	`92.30% <ø> (ø)`
hdfs_datanode	`89.63% <ø> (ø)`
hdfs_namenode	`86.60% <ø> (ø)`
hive	`51.42% <ø> (ø)`
hivemq	`61.90% <ø> (ø)`
http_check	`94.25% <ø> (ø)`
hudi	`73.91% <ø> (ø)`
ibm_db2	`86.29% <ø> (ø)`
ibm_i	`82.36% <ø> (ø)`
ignite	`46.66% <ø> (ø)`
impala	`97.97% <ø> (ø)`
istio	`77.86% <ø> (ø)`
jboss_wildfly	`47.36% <ø> (ø)`
kafka	`64.70% <ø> (ø)`
karpenter	`95.06% <ø> (ø)`
kong	`88.42% <ø> (ø)`
kube_apiserver_metrics	`97.75% <ø> (ø)`
kube_controller_manager	`97.88% <ø> (ø)`
kube_dns	`95.94% <ø> (ø)`
kube_metrics_server	`94.87% <ø> (ø)`
kube_proxy	`96.80% <ø> (ø)`
kube_scheduler	`97.92% <ø> (ø)`
kubeflow	`93.22% <ø> (ø)`
kubelet	`91.09% <ø> (ø)`
kubernetes_cluster_autoscaler	`93.22% <ø> (ø)`
kubernetes_state	`89.49% <ø> (ø)`
kubevirt_api	`82.75% <ø> (ø)`
kubevirt_controller	`85.36% <ø> (ø)`
kubevirt_handler	`91.32% <ø> (ø)`
kyototycoon	`85.96% <ø> (ø)`
kyverno	`82.27% <ø> (ø)`
lighttpd	`83.64% <ø> (ø)`
linkerd	`84.70% <ø> (ø)`
linux_proc_extras	`96.20% <ø> (ø)`
mapr	`82.70% <ø> (ø)`
mapreduce	`81.99% <ø> (ø)`
marathon	`83.06% <ø> (ø)`
mcache	`93.48% <ø> (ø)`
mesos_master	`89.71% <ø> (ø)`
mesos_slave	`93.56% <ø> (ø)`
nagios	`89.01% <ø> (ø)`
network	`93.77% <ø> (ø)`
nfsstat	`95.20% <ø> (ø)`
nginx	`94.65% <ø> (ø)`
nginx_ingress_controller	`98.55% <ø> (ø)`
nvidia_nim	`93.10% <ø> (ø)`
nvidia_triton	`88.52% <ø> (ø)`
openldap	`96.33% <ø> (ø)`
openmetrics	`98.05% <ø> (ø)`
openstack	`55.11% <ø> (ø)`
pgbouncer	`91.66% <ø> (ø)`
php_fpm	`90.45% <ø> (ø)`
postfix	`88.04% <ø> (ø)`
powerdns_recursor	`96.65% <ø> (ø)`
presto	`59.09% <ø> (ø)`
process	`85.99% <ø> (ø)`
prometheus	`94.17% <ø> (ø)`
proxysql	`98.97% <ø> (ø)`
pulsar	`100.00% <ø> (ø)`
rethinkdb	`98.27% <ø> (ø)`
riak	`99.21% <ø> (ø)`
riakcs	`88.82% <ø> (ø)`
silk	`93.82% <ø> (ø)`
singlestore	`90.81% <ø> (ø)`
slurm	`88.88% <ø> (ø)`
snowflake	`96.27% <ø> (ø)`
solr	`56.25% <ø> (ø)`
spark	`93.47% <ø> (ø)`
squid	`100.00% <ø> (ø)`
ssh_check	`92.20% <ø> (-0.87%)`	⬇️
statsd	`87.36% <ø> (ø)`
strimzi	`89.78% <ø> (ø)`
supervisord	`90.14% <ø> (ø)`
system_core	`92.52% <ø> (ø)`
system_swap	`98.30% <ø> (ø)`
tcp_check	`90.72% <ø> (ø)`
tekton	`82.30% <ø> (ø)`
teleport	`99.61% <ø> (ø)`
temporal	`100.00% <ø> (ø)`
teradata	`94.27% <ø> (ø)`
tibco_ems	`91.98% <ø> (ø)`
tls	`91.78% <ø> (ø)`
torchserve	`97.32% <ø> (ø)`
traefik_mesh	`76.75% <ø> (ø)`
traffic_server	`96.13% <ø> (ø)`
twemproxy	`79.45% <ø> (ø)`
twistlock	`80.41% <ø> (ø)`
varnish	`84.22% <ø> (ø)`
vllm	`93.10% <ø> (ø)`
weaviate	`76.27% <ø> (ø)`
win32_event_log	`82.55% <ø> (ø)`
wmi_check	`97.50% <ø> (ø)`
yarn	`89.93% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

github-actions · 2024-11-29T13:59:37Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions · 2024-11-29T14:57:49Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

kayayarai

Caught one missed change from 12 to 13, but otherwise, the docs update is good.

kayayarai · 2024-11-29T15:44:44Z

docs/developer/meta/ci/testing.md

@@ -113,7 +113,7 @@ Configuration for targets [lives](https://github.com/DataDog/integrations-core/b
 | --- | --- | --- |
 | Linux | `linux` | [Ubuntu 22.04](https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md) |
 | Windows | `windows` | [Windows Server 2022](https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md) |
-| macOS | `macos` | [macOS 12](https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md) |
+| macOS | `macos` | [macOS 12](https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md) |


Thanks for spotting this!

github-actions · 2024-11-29T15:45:52Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Co-authored-by: Kari Halsted <[email protected]>

github-actions · 2024-11-29T15:57:03Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions · 2024-11-29T22:10:51Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions · 2024-12-02T16:50:54Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

FlorentClarret · 2024-12-02T17:00:53Z

.github/workflows/build-ddev.yml

@@ -80,9 +80,9 @@ jobs:
          os: windows-2022
        # macOS
        - target: aarch64-apple-darwin
-          os: macos-12
+          os: macos-13


have you tried with 15?

@FlorentClarret I haven't tried 15 - the reasoning for upgrading to 13 rather than jumping directly to 15 is that we want to minimize the chance of compatibility problems with 13.

nubtron · 2024-12-02T17:42:45Z

@iliakur @FlorentClarret thanks for the reviews!

github-actions · 2024-12-02T17:43:12Z

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

* Upgrade GitHub Actions mac runner. * Add changelog. * Fix changelog PR number. * Update docs/developer/meta/ci/testing.md Co-authored-by: Kari Halsted <[email protected]> --------- Co-authored-by: Kari Halsted <[email protected]> d02004e

Upgrade GitHub Actions mac runner.

c7d70ae

datadog-assets bot added agent/review-requested docs/review-requested ecosystems/review-requested product/review-requested labels Nov 28, 2024

nubtron added 2 commits November 29, 2024 14:20

Add changelog.

135dd93

Fix changelog PR number.

1bf4074

Merge branch 'master' into nubtron/upgrade-gha-mac-runner

094fb1e

nubtron marked this pull request as ready for review November 29, 2024 15:19

nubtron requested review from a team as code owners November 29, 2024 15:19

kayayarai previously approved these changes Nov 29, 2024

View reviewed changes

datadog-assets bot added docs/approved and removed docs/review-requested labels Nov 29, 2024

Update docs/developer/meta/ci/testing.md

3e45531

Co-authored-by: Kari Halsted <[email protected]>

nubtron dismissed kayayarai’s stale review via 3e45531 November 29, 2024 15:56

datadog-assets bot added docs/review-requested and removed docs/approved labels Nov 29, 2024

kayayarai approved these changes Nov 29, 2024

View reviewed changes

datadog-assets bot added docs/approved and removed docs/review-requested labels Nov 29, 2024

iliakur approved these changes Dec 2, 2024

View reviewed changes

datadog-assets bot added the agent/approved label Dec 2, 2024

datadog-assets bot removed the agent/review-requested label Dec 2, 2024

FlorentClarret approved these changes Dec 2, 2024

View reviewed changes

Merge branch 'master' into nubtron/upgrade-gha-mac-runner

776eade

nubtron enabled auto-merge December 2, 2024 17:43

nubtron added this pull request to the merge queue Dec 2, 2024

Merged via the queue into master with commit d02004e Dec 2, 2024
388 of 390 checks passed

nubtron deleted the nubtron/upgrade-gha-mac-runner branch December 2, 2024 17:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade GitHub Actions mac runner. #19163

Upgrade GitHub Actions mac runner. #19163

nubtron commented Nov 28, 2024 •

edited

Loading

codecov bot commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

kayayarai left a comment

kayayarai Nov 29, 2024

nubtron Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Dec 2, 2024

FlorentClarret Dec 2, 2024

nubtron Dec 2, 2024

nubtron commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

	\| macOS \| `macos` \| [macOS 12](https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md) \|
	\| macOS \| `macos` \| [macOS 13](https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md) \|

Upgrade GitHub Actions mac runner. #19163

Upgrade GitHub Actions mac runner. #19163

Conversation

nubtron commented Nov 28, 2024 • edited Loading

What does this PR do?

Review checklist (to be filled by reviewers)

codecov bot commented Nov 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

kayayarai left a comment

Choose a reason for hiding this comment

kayayarai Nov 29, 2024

Choose a reason for hiding this comment

nubtron Nov 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Nov 29, 2024

github-actions bot commented Dec 2, 2024

FlorentClarret Dec 2, 2024

Choose a reason for hiding this comment

nubtron Dec 2, 2024

Choose a reason for hiding this comment

nubtron commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

nubtron commented Nov 28, 2024 •

edited

Loading

codecov bot commented Nov 28, 2024 •

edited

Loading