Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog type for downloader #19150

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Nov 27, 2024

What does this PR do?

Motivation

I used the "added" type out of inertia, that's what we had in example PRs in the past.

I thought about it some more however and this is a breaking change IMO. So the changelog should reflect that.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@iliakur iliakur added this pull request to the merge queue Nov 27, 2024
Merged via the queue into master with commit f5d2802 Nov 27, 2024
42 of 44 checks passed
@iliakur iliakur deleted the ik/fix-changelog-type-in-downloader branch November 27, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants