Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDMII-3147] update Cisco IP SLA metrics #19079

Merged
merged 8 commits into from
Nov 19, 2024
Merged

[NDMII-3147] update Cisco IP SLA metrics #19079

merged 8 commits into from
Nov 19, 2024

Conversation

jedupau
Copy link
Contributor

@jedupau jedupau commented Nov 18, 2024

What does this PR do?

This PR adds some tags on existing Cisco IP SLA metrics and update their description which was not clear enough.

Motivation

Some customers wants us to support Cisco IP SLA but we already have some metrics in our _cisco-generic profile, so updating the description will hopefully make them for visible

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (6daceec) to head (0095157).
Report is 4 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
snmp 95.71% <100.00%> (-0.02%) ⬇️
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@jedupau jedupau added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit c875ec6 Nov 19, 2024
38 checks passed
@jedupau jedupau deleted the jed/cisco-ipsla branch November 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants