Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Up Trace Uploads in GHA #19078

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Speed Up Trace Uploads in GHA #19078

merged 6 commits into from
Nov 19, 2024

Conversation

nubtron
Copy link
Contributor

@nubtron nubtron commented Nov 18, 2024

Motivation

@vivek-datadog noticed that the "Upload Traces" workflow in CI was taking half to two-thirds of the total test time, on master test runs. Optimizing that part is definitely a low-hanging fruit!

What does this PR do?

This PR speeds up the "trace upload" workflow so that it runs in 2 minutes instead of 50 minutes, for the master test runs. The total test time was 1.5 - 2 hours before this change.

A large amount of logging was slowing down the GitHub actions job.

The agent log level is now set to "warn" instead of "trace". Also, only the test name and the HTTP status code are now printed, instead of the full response from the Agent:

/// Replaying: Appgate SDP
200 OK
200 OK
/// Replaying: ArangoDB
200 OK
/// Replaying: Argo Rollouts
200 OK
/// Replaying: Argo Workflows
200 OK
/// Replaying: ArgoCD
200 OK
/// Replaying: Avi Vantage
200 OK
200 OK
200 OK

Example fast trace upload (with the changes in this PR): https://github.com/DataDog/integrations-core/actions/runs/11895100489/job/33147224198?pr=19078
Example slow speed (without the changes in this PR): https://github.com/DataDog/integrations-core/actions/runs/11862839027/job/33064564080

This PR probably won't have a big impact on PR test runs (unless a lot of integrations are modified).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

Test Results

   657 files   - 1     657 suites   - 1   4h 58m 48s ⏱️ + 3m 25s
 7 467 tests ±0   7 389 ✅  - 1     78 💤 +1  0 ❌ ±0 
26 382 runs   - 1  22 550 ✅  - 1  3 832 💤 ±0  0 ❌ ±0 

Results for commit bfe809d. ± Comparison against base commit 6daceec.

This pull request skips 1 test.
windows_service.tests.test_windows_service ‑ test_basic_e2e

@nubtron nubtron marked this pull request as ready for review November 18, 2024 16:55
@nubtron nubtron requested a review from a team as a code owner November 18, 2024 16:55
@nubtron nubtron added the qa/skip-qa Automatically skip this PR for the next QA label Nov 18, 2024
@nubtron nubtron added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit f3dbc6b Nov 19, 2024
49 of 50 checks passed
@nubtron nubtron deleted the nubtron/optimize-ci-traces branch November 19, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants