Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinnaker integration #19020

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Spinnaker integration #19020

wants to merge 63 commits into from
+2,225 −0

Conversation

yogesh-s-modak
Copy link

What does this PR do?

PR includes Spinnaker integration including all assets like dashboards, image, README content, etc.

Motivation

This is beta release of agent integration and is intended for internal testing before going live.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@yogesh-s-modak yogesh-s-modak requested review from a team as code owners November 8, 2024 12:37
@datadog-agent-integrations-bot datadog-agent-integrations-bot bot added documentation release qa/skip-qa Automatically skip this PR for the next QA labels Nov 8, 2024
@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@github-actions GitHub Actions
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

iliakur
iliakur reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few tips for how to address failing validations.

@yogesh-s-modak fyi much of this can be avoided by running ddev create as you start developing the integration.

spinnaker/changelog.d/19020.changed Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to 19020.added and change the contents to something like Add Spinnaker Integration OR Add integration.

spinnaker/datadog_checks/spinnaker/__about__.py Outdated
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)

__version__ = '1.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = '1.0.0'
__version__ = '0.0.1'

To pass the changelog validation.

vonage/CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo these changes, we should focus on Spinnaker in this PR. No Vonage files should be affected.

iliakur
iliakur reviewed Nov 15, 2024
View reviewed changes
spinnaker/CHANGELOG.md Outdated
Comment on lines 5 to 10
## 1.0.0 / 2024-11-12

***Added***:

* Initial Release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.0.0 / 2024-11-12
***Added***:
* Initial Release

Another catch to pass validation.

steveny91
steveny91 reviewed Nov 20, 2024
View reviewed changes
spinnaker/CHANGELOG.md Outdated Show resolved Hide resolved
steveny91
steveny91 reviewed Nov 20, 2024
View reviewed changes
spinnaker/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 left review comments

@iliakur iliakur iliakur left review comments

@pranav-sacumen pranav-sacumen pranav-sacumen requested changes

@jhgilbert jhgilbert Awaiting requested review from jhgilbert

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent/review-requested dev/testing dev/tooling docs/review-requested documentation ecosystems/review-requested editorial review Waiting on a more in-depth review from a docs team editor integration/vonage product/review-requested qa/skip-qa Automatically skip this PR for the next QA release team/agent-integrations team/documentation team/logs-backend team/saas-integrations team/siem-logs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yogesh-s-modak @jhgilbert @iliakur @steveny91 @pranav-sacumen @estherk15