Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Prometheus classes and utilities #18863

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Oct 17, 2024

What does this PR do?

We must wait to merge this until #18861 gets merged.

As we no longer ship the Prometheus check, we can get rid of the base class and accompanying utilities.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (451b8b8) to head (abfae6d).

Additional details and impacted files
Flag Coverage Δ
activemq 52.80% <ø> (?)
activemq_xml 82.20% <ø> (ø)
amazon_msk 89.19% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
appgate_sdp 93.93% <ø> (ø)
arangodb 98.23% <ø> (ø)
argo_rollouts 90.00% <ø> (ø)
argo_workflows 87.87% <ø> (ø)
argocd 87.23% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 91.35% <ø> (ø)
aws_neuron 92.42% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 83.33% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (?)
cert_manager 77.41% <ø> (ø)
cisco_aci 89.59% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloud_foundry_api 96.11% <ø> (ø)
cloudera 99.51% <ø> (ø)
consul 91.92% <ø> (ø)
coredns 95.65% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_downloader 81.35% <ø> (+3.23%) ⬆️
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 93.54% <ø> (ø)
ddev 87.46% <ø> (-0.02%) ⬇️
directory 96.46% <ø> (ø)
disk 89.44% <ø> (ø)
dns_check 93.81% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 83.71% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 84.32% <ø> (ø)
fluxcd 88.31% <ø> (ø)
fly_io 97.13% <ø> (ø)
glusterfs 80.00% <ø> (ø)
go_expvar 92.66% <ø> (ø)
gunicorn 92.16% <ø> (ø)
hdfs_datanode 89.63% <ø> (ø)
hdfs_namenode 86.60% <ø> (ø)
hive 51.42% <ø> (?)
hivemq 61.90% <ø> (?)
http_check 94.25% <ø> (ø)
ibm_i 82.36% <ø> (ø)
ignite 46.66% <ø> (?)
istio 77.86% <ø> (ø)
jboss_wildfly 47.36% <ø> (?)
kafka 64.70% <ø> (?)
karpenter 95.06% <ø> (ø)
kube_apiserver_metrics 97.75% <ø> (ø)
kube_controller_manager 97.88% <ø> (ø)
kube_dns 95.94% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubeflow 93.22% <ø> (ø)
kubelet 91.09% <ø> (ø)
kubernetes_cluster_autoscaler 93.22% <ø> (ø)
kubernetes_state 89.49% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
kyverno 82.27% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 84.70% <ø> (ø)
linux_proc_extras 96.20% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.99% <ø> (ø)
marathon 83.06% <ø> (ø)
mcache 93.48% <ø> (ø)
mesos_master 89.71% <ø> (ø)
mesos_slave 93.56% <ø> (ø)
nagios 89.01% <ø> (ø)
network 80.73% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.55% <ø> (ø)
nvidia_triton 88.52% <ø> (ø)
openmetrics 98.05% <ø> (ø)
openstack 55.11% <ø> (ø)
php_fpm 90.45% <ø> (ø)
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto 59.09% <ø> (?)
process 85.99% <ø> (ø)
pulsar 100.00% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 88.82% <ø> (ø)
silk 93.82% <ø> (ø)
singlestore 90.81% <ø> (ø)
snowflake 96.27% <ø> (ø)
solr 56.25% <ø> (?)
squid 100.00% <ø> (ø)
ssh_check 92.20% <ø> (ø)
statsd 87.36% <ø> (ø)
supervisord 90.14% <ø> (ø)
system_core 92.52% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 90.72% <ø> (ø)
teleport 99.61% <ø> (ø)
teradata 94.27% <ø> (ø)
tibco_ems 91.98% <ø> (ø)
tls 91.78% <ø> (ø)
torchserve 97.32% <ø> (ø)
traefik_mesh 76.75% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 80.41% <ø> (ø)
vllm 93.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@iliakur iliakur marked this pull request as draft October 17, 2024 13:36
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@iliakur iliakur marked this pull request as ready for review October 21, 2024 10:04
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@iliakur iliakur added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit 1da51b7 Oct 21, 2024
341 of 346 checks passed
@iliakur iliakur deleted the ik/AI-4133/base-check-drop-prometheus branch October 21, 2024 13:08
github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
* Remove Prometheus classes and utilities

* add changelog 1da51b7
iliakur added a commit that referenced this pull request Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
* Revert "Sunset Prometheus check (#18861)"

This reverts commit 4fb29f2.

* Revert "Remove Prometheus classes and utilities (#18863)"

This reverts commit 1da51b7.
github-actions bot pushed a commit that referenced this pull request Oct 24, 2024
* Revert "Sunset Prometheus check (#18861)"

This reverts commit 4fb29f2.

* Revert "Remove Prometheus classes and utilities (#18863)"

This reverts commit 1da51b7. 007064f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants