Capture stdout and stderr when executing docker compose #18859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
lu-zhengda
previously approved these changes
Oct 17, 2024
nenadnoveljic
force-pushed
the
nenadnoveljic/test-ci
branch
from
e9b5b62
to
4ebee2c
Compare
nenadnoveljic
changed the title
HadhemiDD
previously approved these changes
Oct 21, 2024
iliakur
requested changes
Oct 21, 2024
added change log entry |
lu-zhengda
approved these changes
Oct 21, 2024
lu-zhengda
approved these changes
Oct 21, 2024
iliakur
approved these changes
Oct 21, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
* commit * linter * get compose logs * linter * linter * import SubprocessError * fix SubprocessError * remove -f * capture output * linter * docker compose output * remove import subprocesserror * removed capture * force ci * capture * propagate capture * propagate capture * self.capture * linter * test case for docker_run capture=True * restored README.md * add change log 849a253
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Capture
stdoutstderrofdocker composein case of error.Motivation
This is essential for troubleshooting.
Additional Notes
We can't hardcode
capture=Truein the docker compose call because some integrations, like Confluence, exceed the maximum argument limit, causing an error:Therefore, the caller of
docker_rundecides whether thedocker composeoutput should be captured.Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged