Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDSaaS: Shopify: Crawler integration without Assets #18653

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

akaila-crest
Copy link
Contributor

What does this PR do?

PR includes skeleton of Shopify integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

aliciascott
aliciascott previously approved these changes Oct 4, 2024
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, appreciate the extra info so we knew it was just a "shell" copy for now :)

iliakur
iliakur previously approved these changes Oct 14, 2024
@ashah-crest ashah-crest dismissed stale reviews from iliakur and aliciascott via e512d6a November 7, 2024 06:43
aliciascott
aliciascott previously approved these changes Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants