-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDSaaS: Shopify: Crawler integration without Assets #18653
Open
akaila-crest
wants to merge
12
commits into
DataDog:master
Choose a base branch
from
bhargavnariyanicrest:shopify-v1.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
changelog/no-changelog
dev/testing
dev/tooling
qa/skip-qa
Automatically skip this PR for the next QA
labels
Sep 24, 2024
aliciascott
previously approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, appreciate the extra info so we knew it was just a "shell" copy for now :)
iliakur
previously approved these changes
Oct 14, 2024
aliciascott
previously approved these changes
Nov 7, 2024
cmlaverdiere
approved these changes
Nov 18, 2024
aliciascott
approved these changes
Nov 19, 2024
aliciascott
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/approved
changelog/no-changelog
dev/testing
dev/tooling
docs/approved
documentation
ecosystems/review-requested
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
team/agent-integrations
team/documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR includes skeleton of Shopify integration without any assets like dashboards, image, README content, etc.
Motivation
This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.
Additional Notes
Only crawler-based integration related changes are included in this PR.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged