[PLINT-469] Add Octopus Deploy integration #18488
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datadog-agent-integrations-bot
bot
added
documentation
release
qa/skip-qa
|
The |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The |
|
The |
|
The |
|
The |
sarah-witt
changed the title
|
The |
* Add support for server node metrics * add server node mocks * remove task id tag * update caddyfile
neko-dd
reviewed
Oct 17, 2024
octopus_deploy/README.md
Outdated
|
|
||
| ### Configuration | ||
|
|
||
| 1. Edit the `octopus_deploy.d/conf.yaml` file, in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your octopus_deploy performance data. See the [sample octopus_deploy.d/conf.yaml][4] for all available configuration options. |
There was a problem hiding this comment.
Suggested change
| 1. Edit the `octopus_deploy.d/conf.yaml` file, in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your octopus_deploy performance data. See the [sample octopus_deploy.d/conf.yaml][4] for all available configuration options. | |
| 1. Edit the `octopus_deploy.d/conf.yaml` file in the `conf.d/` folder at the root of your Agent's configuration directory to start collecting your `octopus_deploy` performance data. See the [sample `octopus_deploy.d/conf.yaml`][4] for all available configuration options. |
octopus_deploy/README.md
Outdated
Comment on lines
7
to
10
| Include a high level overview of what this integration does: | ||
| - What does your product do (in 1-2 sentences)? | ||
| - What value will customers get from this integration, and why is it valuable to them? | ||
| - What specific data will your integration monitor, and what's the value of that data? |
There was a problem hiding this comment.
This needs to be replaced with actual content
There was a problem hiding this comment.
Updated, thanks!
octopus_deploy/README.md
Outdated
Comment on lines
43
to
45
| The Octopus Deploy integration does not include any service checks. | ||
|
|
||
| See [service_checks.json][8] for a list of service checks provided by this integration. |
There was a problem hiding this comment.
These appear to be at odds with each other. Which is correct?
| required: true | ||
| - name: project_groups | ||
| description: | | ||
| filter your integration by project groups and projects. |
There was a problem hiding this comment.
Suggested change
| filter your integration by project groups and projects. | |
| Filter your integration by project groups and projects. |
jose-manuel-almaza
previously approved these changes
Oct 18, 2024
HadhemiDD
previously approved these changes
Oct 21, 2024
sarah-witt
dismissed stale reviews from HadhemiDD and jose-manuel-almaza
via
75396e8
HadhemiDD
previously approved these changes
Oct 24, 2024
* Fix new deployment logic and support in progress and queued deployments * sync metadata * update caddyfile * fix * add to completed date * Refactor * fixed e2e tests * fixed instance fixture * fixed e2e test * added some e2e asserts * fixed lint error * all metrics asserted * Add test asserting metadata, add test and handle failure of tasks * store base tags * Don't report completed and executing metrics if no data * Add support for octopus server node metrics * remove unused constants * validate * lint * update e2e * update metadata * Use project name and project group name tags * Use space name instead of space id * Update log lines * update test instance * Update metric description --------- Co-authored-by: Jose Manuel Almaza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an integration for octopus deploy
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged