Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate validate http to ddev #15526

Merged
merged 11 commits into from
Aug 11, 2023
Merged

Migrate validate http to ddev #15526

merged 11 commits into from
Aug 11, 2023

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Aug 9, 2023

What does this PR do?

Migrate ddev validate http command from datadog_checks_dev to ddev.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@swang392 swang392 requested review from a team as code owners August 9, 2023 20:37
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Test Results

     28 files       28 suites   22m 14s ⏱️
   849 tests    844 ✔️   5 💤 0 ❌
1 900 runs  1 837 ✔️ 63 💤 0 ❌

Results for commit d9a6a50.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #15526 (d9a6a50) into master (b03918e) will increase coverage by 0.09%.
The diff coverage is 98.43%.

Flag Coverage Δ
datadog_checks_dev 82.56% <ø> (+0.07%) ⬆️
ddev 99.47% <100.00%> (+0.01%) ⬆️
kube_apiserver_metrics 97.85% <100.00%> (ø)
kubelet 91.00% <100.00%> (ø)
marklogic 96.51% <100.00%> (ø)
openstack 51.45% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ofek
ofek requested changes Aug 10, 2023
View reviewed changes
ddev/src/ddev/cli/validate/http.py Outdated Show resolved Hide resolved
ddev/tests/cli/validate/test_http.py Outdated Show resolved Hide resolved
ddev/tests/cli/validate/test_http.py Outdated Show resolved Hide resolved
@ofek ofek requested a review from a team as a code owner August 11, 2023 15:38
@ofek ofek changed the title migrate ddev validate http to ddev Migrate validate http to ddev Aug 11, 2023
@ofek ofek requested a review from a team as a code owner August 11, 2023 15:50
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@ofek ofek merged commit f301607 into master Aug 11, 2023
52 checks passed
@ofek ofek deleted the swang392/migrate-validate-http branch August 11, 2023 19:21
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@ofek
Migrate validate http to ddev (#15526)
d7e512c 
* migrate `ddev validate http` to ddev

* style fixes

* style fixes cont

* remove extra commented test

* style fix

* update validation tracker count

* cleanup

* Update test_changelog.py

* remove

* .

---------

Co-authored-by: Ofek Lev <[email protected]> f301607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek requested changes

@brett0000FF brett0000FF brett0000FF approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog ddev dev_package dev/tooling documentation integration/kube_apiserver_metrics integration/kubelet integration/marklogic integration/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swang392 @ofek @brett0000FF