-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sending database_instance metadata #15524
Merged
alexandre-normand
merged 12 commits into
master
from
alex.normand/DBM-2622-mysql-database-instance-metadata
Aug 16, 2023
Merged
Add support for sending database_instance metadata #15524
alexandre-normand
merged 12 commits into
master
from
alex.normand/DBM-2622-mysql-database-instance-metadata
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The |
alexandre-normand
force-pushed
the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
from
August 10, 2023 03:38
5757fb1
to
e2a6bf2
Compare
drichards-87
previously approved these changes
Aug 10, 2023
alexandre-normand
force-pushed
the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
from
August 10, 2023 15:40
2a29191
to
5bd5f5c
Compare
lu-zhengda
reviewed
Aug 11, 2023
lu-zhengda
reviewed
Aug 11, 2023
alexandre-normand
force-pushed
the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
from
August 11, 2023 16:47
6e21b89
to
1945742
Compare
lu-zhengda
previously approved these changes
Aug 11, 2023
alexandre-normand
force-pushed
the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
from
August 11, 2023 18:37
5c15053
to
764def9
Compare
alexandre-normand
force-pushed
the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
from
August 11, 2023 18:52
764def9
to
b459b7b
Compare
lu-zhengda
approved these changes
Aug 16, 2023
alexandre-normand
deleted the
alex.normand/DBM-2622-mysql-database-instance-metadata
branch
August 16, 2023 01:16
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds sending of a new metadata kind:
database_instance
. This doesn't require any new queries to collect the data as it's inferred from configuration and things collected during initialization (like version).Motivation
We'd like to keep a better inventory of database instances regardless of whether dbm is enabled or not. We already have a concept of
database_instance
but this makes it a more direct element of collected information rather than something that is inferred / implicit from other data we collect.Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.