Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending database_instance metadata #15524

Merged

Conversation

alexandre-normand
Copy link
Contributor

What does this PR do?

This adds sending of a new metadata kind: database_instance. This doesn't require any new queries to collect the data as it's inferred from configuration and things collected during initialization (like version).

Motivation

We'd like to keep a better inventory of database instances regardless of whether dbm is enabled or not. We already have a concept of database_instance but this makes it a more direct element of collected information rather than something that is inferred / implicit from other data we collect.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Test Results

     16 files       16 suites   44m 47s ⏱️
   138 tests    138 ✔️ 0 💤 0
1 104 runs  1 095 ✔️ 9 💤 0

Results for commit ac49e9c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #15524 (ac49e9c) into master (5b46a17) will increase coverage by 0.00%.
The diff coverage is 95.23%.

Flag Coverage Δ
mysql 87.37% <95.23%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alexandre-normand alexandre-normand force-pushed the alex.normand/DBM-2622-mysql-database-instance-metadata branch from 5757fb1 to e2a6bf2 Compare August 10, 2023 03:38
@alexandre-normand alexandre-normand marked this pull request as ready for review August 10, 2023 04:46
@alexandre-normand alexandre-normand requested a review from a team as a code owner August 10, 2023 04:46
drichards-87
drichards-87 previously approved these changes Aug 10, 2023
@alexandre-normand alexandre-normand force-pushed the alex.normand/DBM-2622-mysql-database-instance-metadata branch from 2a29191 to 5bd5f5c Compare August 10, 2023 15:40
@alexandre-normand alexandre-normand added this to the 7.48 milestone Aug 10, 2023
@alexandre-normand alexandre-normand force-pushed the alex.normand/DBM-2622-mysql-database-instance-metadata branch from 6e21b89 to 1945742 Compare August 11, 2023 16:47
lu-zhengda
lu-zhengda previously approved these changes Aug 11, 2023
@alexandre-normand alexandre-normand force-pushed the alex.normand/DBM-2622-mysql-database-instance-metadata branch from 764def9 to b459b7b Compare August 11, 2023 18:52
@alexandre-normand alexandre-normand merged commit ca3c9ec into master Aug 16, 2023
27 checks passed
@alexandre-normand alexandre-normand deleted the alex.normand/DBM-2622-mysql-database-instance-metadata branch August 16, 2023 01:16
@vivek-datadog vivek-datadog mentioned this pull request Aug 16, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants