Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate validate ci to ddev #15497

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Migrate validate ci to ddev #15497

merged 2 commits into from
Aug 8, 2023

Conversation

swang392
Copy link
Contributor

@swang392 swang392 commented Aug 7, 2023

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test Results

    2 files      2 suites   3m 7s ⏱️
286 tests 281 ✔️   5 💤 0
572 runs  552 ✔️ 20 💤 0

Results for commit edeaebb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #15497 (edeaebb) into master (2b91998) will increase coverage by 0.01%.
Report is 24 commits behind head on master.
The diff coverage is 100.00%.

Flag Coverage Δ
ddev 99.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@swang392 swang392 marked this pull request as ready for review August 8, 2023 14:49
@swang392 swang392 requested a review from a team as a code owner August 8, 2023 14:49
ddev/hatch.toml Outdated Show resolved Hide resolved
ddev/src/ddev/cli/validate/ci.py Outdated Show resolved Hide resolved
ddev/src/ddev/cli/validate/ci.py Outdated Show resolved Hide resolved
ddev/src/ddev/cli/validate/ci.py Outdated Show resolved Hide resolved
@ofek ofek merged commit cb539e3 into master Aug 8, 2023
41 checks passed
@ofek ofek deleted the swang392/migrate-validate-ci branch August 8, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants