Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Update Resources #15494

Merged
merged 6 commits into from
Aug 9, 2023
Merged

OpenAI Update Resources #15494

merged 6 commits into from
Aug 9, 2023

Conversation

cmlaverdiere
Copy link
Contributor

@cmlaverdiere cmlaverdiere commented Aug 7, 2023 •
edited
Loading

What does this PR do?

For the API component of the integration:

  • Readme updates
  • Adds a recommended monitor

Also adds screenshots of dashboards for the entire integration.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@cmlaverdiere cmlaverdiere requested review from a team as code owners August 7, 2023 18:12
rtrieu
rtrieu previously approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

FlorentClarret
FlorentClarret previously approved these changes Aug 8, 2023
View reviewed changes
@cmlaverdiere cmlaverdiere dismissed stale reviews from FlorentClarret and rtrieu via 5c3db1d August 8, 2023 14:48
@cmlaverdiere cmlaverdiere changed the title Update readme with api keys section OpenAI Update Resources Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Yun-Kim
Yun-Kim approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end!

@FlorentClarret FlorentClarret merged commit a071e42 into master Aug 9, 2023
28 checks passed
@FlorentClarret FlorentClarret deleted the chris.laverdiere/openai-docs-update branch August 9, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-Kim Yun-Kim Yun-Kim approved these changes

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@rtrieu rtrieu rtrieu left review comments

@emmettbutler emmettbutler Awaiting requested review from emmettbutler emmettbutler was automatically assigned from DataDog/apm-core-python

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/openai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmlaverdiere @FlorentClarret @Yun-Kim @rtrieu