Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum base package version #15303

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jul 19, 2023

What does this PR do?

Motivation

#15292 and #15298. Otherwise tests that rely on the latest behavior of the OpenMetrics base class would fail when testing against the minimum base version currently specified.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@github-actions
Copy link

Test Results

  4 files    4 suites   34s ⏱️
11 tests 11 ✔️ 0 💤 0
24 runs  17 ✔️ 7 💤 0

Results for commit 361da2a.

@alopezz alopezz merged commit 73fad79 into master Jul 19, 2023
@alopezz alopezz deleted the alopez/openmetrics/bump-min-base branch July 19, 2023 13:36
@vivek-datadog vivek-datadog added the qa/skip-qa Automatically skip this PR for the next QA label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration/openmetrics qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants