-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit critical service check whenever connection fails #15208
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions but looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Alex Lopez <[email protected]>
Co-authored-by: Florent Clarret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if test failures are resolved 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Alex Lopez <[email protected]>
What does this PR do?
Before
We submit CRITICAL service check only if our first connection attempt to mongodb fails. If the connection breaks after the check has run a few times successfully, we continue sending OK service check even if the connection dies.
After
We submit the service check at the very end of the integration check run, at which point we can catch connection errors and submit a CRITICAL service check every time the connection fails.
Motivation
Several support cases. Folks are saying their service check remains OK even though the metric submissions are missing and the logs show connection errors.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.